World Save on shutdown [Windows, Docker Desktop] about valheim-docker HOT 23 CLOSED

Dope managed to solve it, @ExQDev can you try with image mbround18/valheim:sha-2cfb246?

Update: Merged you can now use latest or 1.8.0
https://github.com/mbround18/valheim-docker/releases/tag/v1.8.0

from valheim-docker.

@mbround18 yep, everything is good. tried to stop with a different ways, such as stop button, Ctrl+C, docker-compose down, works well!

from valheim-docker.

Modded?

Give docker-compose.yml - use markdown.

from valheim-docker.

Some fields are changed due to privacy

version: "3"
services:
  valheim:
    image: mbround18/valheim:latest
    ports:
      - 2456:2456/udp
      - 2457:2457/udp
      - 2458:2458/udp
    environment:
      - PORT=2456
      - NAME="name"
      - WORLD="worldname"
      - PASSWORD="password"
      - TZ=Europe/Kyiv
      - PUBLIC=1
      - AUTO_UPDATE=0
      - UPDATE_ON_STARTUP=0
      - TYPE=BepInExFull
      - AUTO_BACKUP=1
      - AUTO_BACKUP_ON_SHUTDOWN=1
      - AUTO_BACKUP_ON_UPDATE=1
      - AUTO_BACKUP_SCHEDULE="*/15 * * * *"
      - AUTO_BACKUP_REMOVE_OLD=1
      - AUTO_BACKUP_DAYS_TO_LIVE=3
      - WEBHOOK_URL=https://discord.com/api/webhooks/.....
      - WEBHOOK_BROADCAST_MESSAGE=1
      - WEBHOOK_INCLUDE_PUBLIC_IP=1
    volumes:
      - ./valheim/saves:/home/steam/.config/unity3d/IronGate/Valheim
      - ./valheim/server:/home/steam/valheim
      - ./valheim/backups:/home/steam/backups
      - ./valheim/logs:/home/steam/valheim/logs

from valheim-docker.

BTW, I'm on windows 10 with Docker Desktop.
No mods, just BepInEx
But clear Valheim behavour the same

from valheim-docker.

Just discovered that the world is finally saved, but it does this too rarely and especially not when necessary. E.g., when shut down. Or reboot. Just maybe once a half an hour or randomly more rare. How I can setup it more frequently and / or right before shutdown?

from valheim-docker.

@ExQDev im very curious to why yours isnt shutting down propery, I build & test the image on my windows machine. Do you have any special docker configurations?

from valheim-docker.

The following en var TYPE=BepInExFull is only really needed for a very small number of mods. I don't have those on hand - and the one that use to require it (and requested by me to add BepInExFull) switched to standard BepInEx awhile ago.

BepInExFull is outdated compared to BepInEx

But clear Valheim behavour the same

Changing from any modded type to TYPE=Vanilla requires a re-install of the server. Going from your docker-compose.yml you would have to (basically) nuke ./valheim/server when switching back and forth.

from valheim-docker.

My docker configuration is basic, almost clear with defaults.
Thank you about BepInEx suggestion, I'll check it out.

from valheim-docker.

Still do no save when shutdown. Periodic 30 min save works, but I need to save when container going off.
As variant, I can save world when I am admin in manual mode, but... This is not the best solution...

from valheim-docker.

On SIGINT the server does save by default.

This is the reason why I added e8346c8

How exactly are you stopping the container? Are you using standard docker-compose down or something else?

from valheim-docker.

I am using these buttons:)

from valheim-docker.

@ExQDev i have not tried it with those buttons, have you tried it with the standard docker commands?

from valheim-docker.

@ExQDev i have not tried it with those buttons, have you tried it with the standard docker commands?

docker-compose down takes the same effect
any docker container stop, except windows shutdown or reboot, fires discord notification, but do not saves world changes

sorry for late, often catch blackouts

from valheim-docker.

@ExQDev Alright, got my windows machine back online going to give it shot

from valheim-docker.

@ExQDev alright built a little shack now gonna just restart the server with the docker desktop

from valheim-docker.

Alright the shack did not survive using the docker desktop

from valheim-docker.

@ExQDev looks like the stop signal is getting processes successfully with the right pid on windows

[ODIN][DEBUG] - Debugging set to true
[ODIN][DEBUG] - Debug mode enabled!
[ODIN][DEBUG] - Launching stop command...
[ODIN][DEBUG] - Checking for notification information...
[ODIN][DEBUG] - Env var default 'WEBHOOK_URL': ''
[ODIN][DEBUG] - Skipping notification, no webhook supplied!
[ODIN][DEBUG] - Env var default 'ODIN_WORKING_DIR': '/home/steam/valheim'
[ODIN][INFO]  - Stopping server /home/steam/valheim
[ODIN][DEBUG] - Env var default 'ODIN_WORKING_DIR': '/home/steam/valheim'
[ODIN][INFO]  - Scanning for Valheim process
[ODIN][INFO]  - Found Process with pid 211! Sending Interrupt!
[ODIN][INFO]  - Process signal interrupt sent successfully!
[ODIN][INFO]  - Waiting for server to completely shutdown...
[ODIN][INFO]  - Server has been shutdown successfully!
[ODIN][DEBUG] - Checking for notification information...
[ODIN][DEBUG] - Env var default 'WEBHOOK_URL': ''
[ODIN][DEBUG] - Skipping notification, no webhook supplied!

from valheim-docker.

But still no reaction with world save..

I saw that everything is correct in container, and it waits for server shutdown itself, but it is in such a hurry to shutdown that it forgets to save the world

from valheim-docker.

@ExQDev I am going to try forcing sigint

https://valheimbugs.featureupvote.com/suggestions/159711/dedicated-server-does-not-save-world-on-sigterm

from valheim-docker.

That did not work or change anything

from valheim-docker.

I think the title of this issue needs to be changed to reflect on which OS this is being ran on.

On Linux, be it within a VM (pick any linux distro) or bare metal this isn't an issue as this image correctly sends SIGINT and valheim correctly shutdowns and saves.

NB: Remember the main dev for Valheim (Iron Gate) runs native linux himself.

from valheim-docker.

Changed title

from valheim-docker.