Code Monkey home page Code Monkey logo

Comments (8)

mbhall88 avatar mbhall88 commented on July 20, 2024

In particular, this issue is concerned with solving problem 2 above.

We can detect whole gene deletions, but not partial deletions which knock out the start codon - which effectively amount to the same thing.

I've seen this issue in both pncA and katG.

from drprg.

mbhall88 avatar mbhall88 commented on July 20, 2024

The implementation of this feature will likely need to change when/if iqbal-lab-org/pandora#316 is closed.

from drprg.

iqbal-lab avatar iqbal-lab commented on July 20, 2024

Do you mean that there is a potential fix even without a fix for iqbal-lab-org/pandora#316 ?

from drprg.

mbhall88 avatar mbhall88 commented on July 20, 2024

Well noticing failed variants that span the start codon would be a kind of band-aid fix. The proper fix would be the resolution of that pandora issue

from drprg.

mbhall88 avatar mbhall88 commented on July 20, 2024

Should we also be detecting when the stop is lost? There are two INH FNs that we miss because we don't detect stop loss and tbprofiler calls stop loss. We have null genotypes spanning the stop codon in both of these samples.

from drprg.

iqbal-lab avatar iqbal-lab commented on July 20, 2024

My guess is yes we should

from drprg.

mbhall88 avatar mbhall88 commented on July 20, 2024

I made a change to the partial gene deletion code and also removed the GT CONF filter. The (Illumina) diff I get from these changes is

Tool Drug ΔFN ΔFP
drprg Amikacin 0 0
drprg Capreomycin 0 0
drprg Delamanid 0 0
drprg Ethambutol -1 1
drprg Ethionamide -13 1
drprg Isoniazid 0 0
drprg Kanamycin 0 0
drprg Levofloxacin -1 0
drprg Linezolid 0 0
drprg Moxifloxacin 0 0
drprg Ofloxacin 0 0
drprg Pyrazinamide -1 0
drprg Rifampicin -1 0
drprg Streptomycin 0 4

Most of these FPs are also FPs on tbprofiler also.


Regarding the stop lost stuff, Miranda made a good point, maybe we just flag it as an unknown mutation?

from drprg.

iqbal-lab avatar iqbal-lab commented on July 20, 2024

Good idea, flag as unknown seems safest.

from drprg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.