Comments (8)
In particular, this issue is concerned with solving problem 2 above.
We can detect whole gene deletions, but not partial deletions which knock out the start codon - which effectively amount to the same thing.
I've seen this issue in both pncA and katG.
from drprg.
The implementation of this feature will likely need to change when/if iqbal-lab-org/pandora#316 is closed.
from drprg.
Do you mean that there is a potential fix even without a fix for iqbal-lab-org/pandora#316 ?
from drprg.
Well noticing failed variants that span the start codon would be a kind of band-aid fix. The proper fix would be the resolution of that pandora issue
from drprg.
Should we also be detecting when the stop is lost? There are two INH FNs that we miss because we don't detect stop loss and tbprofiler calls stop loss. We have null genotypes spanning the stop codon in both of these samples.
from drprg.
My guess is yes we should
from drprg.
I made a change to the partial gene deletion code and also removed the GT CONF filter. The (Illumina) diff I get from these changes is
Tool | Drug | ΔFN | ΔFP |
---|---|---|---|
drprg | Amikacin | 0 | 0 |
drprg | Capreomycin | 0 | 0 |
drprg | Delamanid | 0 | 0 |
drprg | Ethambutol | -1 | 1 |
drprg | Ethionamide | -13 | 1 |
drprg | Isoniazid | 0 | 0 |
drprg | Kanamycin | 0 | 0 |
drprg | Levofloxacin | -1 | 0 |
drprg | Linezolid | 0 | 0 |
drprg | Moxifloxacin | 0 | 0 |
drprg | Ofloxacin | 0 | 0 |
drprg | Pyrazinamide | -1 | 0 |
drprg | Rifampicin | -1 | 0 |
drprg | Streptomycin | 0 | 4 |
Most of these FPs are also FPs on tbprofiler also.
Regarding the stop lost stuff, Miranda made a good point, maybe we just flag it as an unknown mutation?
from drprg.
Good idea, flag as unknown seems safest.
from drprg.
Related Issues (20)
- False positive argmatch results HOT 1
- Run drprg HOT 4
- Add grammar for specifying variant "expert" rules
- Benchmark figures HOT 7
- Parse pandora VCF to detect minor alleles HOT 46
- Update pandora and make_prg HOT 2
- Deal with gene absence HOT 9
- Add some common resistance-conferring mutations that do no exist in population graph HOT 8
- Targeted sequencing mode HOT 1
- Disruptive in-frame indels HOT 3
- Lineage calling HOT 1
- Add install instructions to README.md
- How do i pronounce this tool name HOT 1
- Installation_error HOT 2
- Collate_drprg_results HOT 1
- error: unrecognized subcommand 'index' HOT 4
- Paired-end fastq files HOT 1
- Missing expected output file /test/outdir/discover/denovo_sequences.fa HOT 5
- Index is not valid, missing files error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drprg.