--only-type (forks|sources) about githubcloner HOT 6 CLOSED

Great idea! Feel free to make a PR if you have time

from githubcloner.

Ok, thank you!

from githubcloner.

Hi @teran-mckinney

I checked the PR for errors and issues. I prefered to do in-depth analysis on the update before merging it to not cause issues to users.

1. The main function does not do input check for input regarding --prefix-mode. This is handled within the app in your copy.
   --prefix_mode x crashes the app.

2. The directory mode is not working, since os.mkdir is not recursive. Current version have pass to Exception regarding os.mkdir, which sets it clean to console.

I will do the changes and fixes tonight.

Another change would be to call git without the module, since it's not actually useful, and is leading to a lot of errors.

All the best,
Mazin

from githubcloner.

Hi @teran-mckinney

I merged and reviewed your PR regarding the --prefix-mode addition.

Regarding --only-type, I have found that the API supports it, there is a key called fork. The value is True|False. We can add this feature using this API.

Best Regards,
Mazin

from githubcloner.

Great, thank you! I will have to look into this later.

from githubcloner.

This feature has been added #29. Now you can provide --exclude_forks, and you would be able to filter forks

from githubcloner.