Code Monkey home page Code Monkey logo

Comments (14)

waldyrious avatar waldyrious commented on June 19, 2024 1

Great! Let me know when you know what your availability will be during those days. During the workweek, I am generally available at night (around 8pm-11pm UTC).

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024 1

OAuth authentification is now possible (and recommanded!) in wikibase-cli >= v8, that might (finally) solve your issue \o/
see config documentation

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

no, your normal Wikidata username and password should do normally

from wikibase-cli.

waldyrious avatar waldyrious commented on June 19, 2024

Well, I have my Wikimedia account set up for 2FA, not sure if that interferes here.

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

@waldyrious possibly. Also to have in mind: the current implementation relies on a deprecated query https://github.com/maxlath/wikidata-token/issues/5

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

@waldyrious hey, will you be in Vienna for the Wikimedia Hackathon next week? we could take the occasion to tackle this issue :)

from wikibase-cli.

waldyrious avatar waldyrious commented on June 19, 2024

Unfortunately not :( but we could set up a time to chat over IRC during the hackathon :)

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

sure! I should be able to find knowledgeable people in the room to give us a clue or two ;)

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

so it seems we can take inspiration on @addshore's login code that does support 2FA: MWApi.java

from wikibase-cli.

waldyrious avatar waldyrious commented on June 19, 2024

Great to hear that, @maxlath. However I think the UX needs a little polish:

❯ wd set-label Q4115189 pt "Testing wikidata-cli"
This operation requires to set your crendentials for https://www.wikidata.org
Which authentification mecanism would you like to use to login to https://www.wikidata.org ?:
/!\ Beware that those will be stored in plain text on your computer
1 - OAuth tokens (recommanded)
2 - username - password
- 1

If you don't have OAuth tokens yet, you can request owner-only tokens OAuth consumers at

https://meta.wikimedia.org/wiki/Special:OAuthConsumerRegistration/propose?wpname=wikibase-cli-myusername&wpdescription=tokens%20for%20wikibase-cli%20%28https%3A%2F%2Fgithub.com%2Fmaxlath%2Fwikibase-cli%29&wpownerOnly=1

Select "Request authorization for specific permissions" and adjust to your needs.
Required authorizations:
- Edit existing pages
Recommanded authorizations:
- Create, edit, and move pages

A clear message and call should be shown, e.g. "You don't seem to have an OAuth token set yet; please open the following URL to create one".

Especially since when I open that URL I see this huge and complex form:

Screenshot_2019-10-02 OAuth consumer registration - Meta

...when I expected an authorization screen like those that appear when I authorize a Labs tool on mediawiki.org (i.e. a dialog where I can just click "Authorize").

So although this may work (I didn't continue further), is it OK if I keep this issue open until that flow is smoothed out a bit?

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

So although this may work (I didn't continue further), is it OK if I keep this issue open until that flow is smoothed out a bit?

could you open a new issue on this?

from wikibase-cli.

waldyrious avatar waldyrious commented on June 19, 2024

could you open a new issue on this?

Sure. Something like "Improve authentication flow"?

from wikibase-cli.

maxlath avatar maxlath commented on June 19, 2024

"Improve OAuth authentication flow"?

from wikibase-cli.

waldyrious avatar waldyrious commented on June 19, 2024

Sounds good, will do 👍

from wikibase-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.