Investigate why knobs don't work in Safari about noisecraft HOT 5 CLOSED

I merged #69 from DI-John. This sidesteps the bug in Safari and the knobs now work. There's another issue with pointer capture seemingly not working in Safari (argh wtf!), but the situation for Safari users has improved.

I'll still leave the warning popup suggesting that Safari users should use Chrome enabled, at least until we have a fix for the pointer capture bug.

from noisecraft.

@maximecb Noticed that Safari doesn't receive the expected movementY values on these mouse events, here is a possible workaround:

#67

from noisecraft.

Thanks for taking a look DI-John. I tried out your fix and it seems to work, but I'm a bit confused because:

1. The MDN page lists Safari as supporting MouseEvent.MovementY, but in actuality, my Safari browser reports the value as always being zero (wtf?). So your fix seems to work, but it seems like it shouldn't be needed? The value reported for movementY in Safari is zero, which is different from Chrome and Firefox, and clearly wrong.

2. There's another bug in Safari. When the mouse is released, it triggers the node creation dialog. This should not be happening because of the pointer capture. This is more wacky behavior on the part of Safari, which I'm not sure how to address, besides maybe using an invisible div or something?

from noisecraft.

@maximecb

The MDN page lists Safari as supporting MouseEvent.MovementY, but in actuality, my Safari browser reports the value as always being zero (wtf?)

Yeah, that's what I encountered as well. Perhaps it's a browser bug that only happens in the context of the setPointerCapture / releasePointerCapture. Might be interesting to do some tests using the movementY value in various contexts, perhaps it works just in a regular onmousemove handler without pointer capture.

There's another bug in Safari. When the mouse is released, it triggers the node creation dialog.

Hm, interesting.

from noisecraft.

Pushed a hack which should fix this problem.

from noisecraft.