Investigate encodings and localisation about gphoto2-rs HOT 12 OPEN

I mean in libgphoto2 itself :)

from gphoto2-rs.

I don't have much C experience (and less with the locales, only heard bad things about it), but isn't there a function like setlocale we can use to just set the locale to C to get consistent results regardless of the operating's system locale?

Sorry if what I'm saying makes no sense at all :/

from gphoto2-rs.

Wait nevermind, libgphoto2 already does that: https://github.com/gphoto/libgphoto2/blob/master/ChangeLog#L2249

from gphoto2-rs.

Yeah it does, as well as it has an internal function for overriding the encoding specifically. All I'm saying is that it's worth testing and adding whatever's necessary to make sure that Unicode strings from camera are correctly parsed and converted to UTF-8 that Rust expects regardless of LC_ALL=... environment variable or any other settings (I suspect right now if user sets LC_ALL to a non-UTF8 encoding, and there are non-ASCII strings, we'll get either corruption or runtime panics).

from gphoto2-rs.

If you have camera at hand and it allows settings some strings (e.g. Canon allows to set copyright author name via Digital Photo Professional), it would be good to set that to e.g. Chinese characters, overriding LC_ALL to some non-UTF8 encoding and checking how those characters are parsed by gphoto2-rs.

from gphoto2-rs.

I added an example to test this, unfortunately my camera (a Nikon D3400) does not seem to have any text that I can freely set.

If you have a camera where you can set a text, just adjust the CONFIG_KEY in the example to the widget name.

from gphoto2-rs.

I added an example to test this, unfortunately my camera (a Nikon D3400) does not seem to have any text that I can freely set.

It should have the same copyright field (https://www.dummies.com/article/home-auto-hobbies/photography/add-copyright-notice-images-nikon-d5600-245525/), but seems like it can be set only from the camera, which likely means no Unicode chars.

from gphoto2-rs.

Actually, one other thing you could do is just create a file with unicode chars via file manager when camera is connected, and then checking how it's reported via CameraFS?

from gphoto2-rs.

Actually, one other thing you could do is just create a file with unicode chars via file manager when camera is connected, and then checking how it's reported via CameraFS?

My camera sadly only exposes images to libgphoto2 it has taken and match the naming format :(

I suspect right now if user sets LC_ALL to a non-UTF8 encoding, and there are non-ASCII strings, we'll get either corruption or runtime panics

Will we? AFAICT we are using String::from_utf8_lossy wherever we get a string from libgphoto2, so invalid UTF-8 should not cause a pash

from gphoto2-rs.

so invalid UTF-8 should not cause a pash

Those I count as corruption :P

My camera sadly only exposes images to libgphoto2 it has taken and match the naming format :(

Hm, are you saying that manually added files via file manager are not visible via CameraFS? Fascinating.

from gphoto2-rs.

Anyway, I'll add some unicode chars to the virtual camera to make this easier to verify.

from gphoto2-rs.

Anyway, I'll add some unicode chars to the virtual camera to make this easier to verify.

WDYM? I haven't found any writable TextWidget on the Virtual camera. You don't seem to be able to create or upload files/directories on the virtual camera (the storage access type is RoDelete)

from gphoto2-rs.