Code Monkey home page Code Monkey logo

Comments (4)

maxcountryman avatar maxcountryman commented on May 13, 2024

The Flask route decorator should always be the last decorator over your view function, i.e. your second example is the correct, canonical way to handle route registry. (This is, as far as I know, related to the internals of how Flask handles view registry though you might want to take a closer look at the Flask and Werkzeug source to verify.)

from flask-login.

corydolphin avatar corydolphin commented on May 13, 2024

You are correct, yet it is not entirely obvious to developers. Guidance would help to remove any issues with the use of login_required which has a potentially negative impact. That is the major issue I wished to get across, thus it would be good if guidance was added, if you are open to such a change, I will prepare a small patch to the example and the docs that specifies this explicitly.

from flask-login.

maxcountryman avatar maxcountryman commented on May 13, 2024

Sure. That would be great!

from flask-login.

maxcountryman avatar maxcountryman commented on May 13, 2024

This is now duplicated and having had time to think about it, I don't think it falls on the shoulders of the extensions to document Flask behavior (barring a few necessary exceptions, but certainly not common behavior); basically you should already know this and if you don't it should be up to Flask to document and inform users of this.

from flask-login.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.