Crash mixing Buffers and strings about concat-stream HOT 5 CLOSED

(This is Node v0.10.5 btw.)

from concat-stream.

Thanks for the bug report. This is a limitation of concat-stream... right now it only knows how to process streams where all chunks are the same type. Here's the current implementation https://github.com/maxogden/node-concat-stream/blob/master/index.js#L32-L41, it keeps an array of chunks and then does some pretty simplistic testing to see which concatenation method it should use.

To add support for multiple types of chunks in a single stream it would add some complexity to the code and could be kind of klunky. Also I'm not sure what the correct should be in your situation (new Buffer('foo') and 'bar'), should it return a Buffer with 'foobar' as the contents or a string 'foobar'?

A quick workaround would be to make sure that you .toString() all buffers before writing them to the stream so that you ensure that all chunks are strings, or vice versa with Buffers

from concat-stream.

Seems like a fair limitation. Some ideas:

• Type-cast to the first type encountered?
• Print a warning if there's a type mismatch?
• Throw an error if there's a type mismatch?

from concat-stream.

imo this is an issue with combined-streams. it should cast all the data to a single type (buffers).

https://github.com/stream-utils/combine-streams handles this

from concat-stream.

Sounds good. I guess we can close this then, yes?

from concat-stream.