[REQUEST] Make homemade git buffers actionable with <ret> about kakoune HOT 5 CLOSED

I'm working on finding a solution here. I think a sensible approach is to use filetype=git for diff buffers.
We already use it for git show buffers which are not much different.

from kakoune.

proposed fix is at https://lists.sr.ht/~mawww/kakoune/%[email protected]%3E (it serves a larger series but can be extracted)

from kakoune.

I think it makes sense to map <ret> depending on filetype, not based on which commands where executed to create the buffer.
Note that for git diff we set filetype diff but override the generic diff <ret> mapping with one that always uses the Git toplevel dir (not terribly important though).
In future, git commands might set buffer-local variables for the $PWD (so things work better when there are multiple Git worktrees). So hand crafting a buffer might have some minor downsides.

I like to save my search results in a file with :w grep-controllers. Then to reuse those results, I just open the file and assign it the grep filetype with set buffer filetype grep

you can use :rename-buffer on the *grep* buffer instead

from kakoune.

you can use :rename-buffer on the grep buffer instead

That is a nice tip (as long as you don't want to persist it to disk.

I think it makes sense to map depending on filetype, not based on which commands where executed to create the buffer.

I feel like it would be good practice too.

from kakoune.

I think that could be effectively a good idea and could lead to a cleaner approach.

from kakoune.