Use object.is for equality check about signals HOT 4 CLOSED

It would be but I'm not aware of the performance difference. If there's any benchmarks that we can look at that would help.

from signals.

It is not about performance but reliability. Object.is returns true for Object.is(NaN, NaN) and false for Object.is(0, -0).

Since there is no implicit type conversion, it should be faster than ===.

from signals.

Performance is extremely important for our signals implementation, especially as the reacitvity graph becomes more deep. We have thousands of computations in our libraries that use this. Most rely on signals purely for performance. The trade off for checking something super rare like NaN, NaN and -0, +0 needs to be justified.

from signals.

I could not find any definitive benchmark results that runs extensive checks. I did run some using mitata, performance difference is marginal, which favors either of them depending on the compared values and the runtime.

from signals.