Comments (4)
tulir
commented on August 20, 2024
Using Fprint instead of Fprintln in the push event handler should fix it. I'll see if I have some time to fix this and the other easy issues some time soon.
from gitlab.
afranke
commented on August 20, 2024
Awesome, thanks a lot!
from gitlab.
afranke
commented on August 20, 2024
The situation is a lot better, but there is still an extra \n at the end of the commit list because of the \n after the </li> in https://github.com/maubot/gitlab/blob/master/gitlab-webhook.go#L111
from gitlab.
tulir
commented on August 20, 2024
Removing that would very likely make the plaintext fallback much worse. Besides, ignoring newlines isn't something Riot does, newlines in HTML are ignored unless they're in a preformatted block
Anyway, I'm going to rewrite the bot to use the maubot platform soon, which uses Markdown for formatted messages and a more advanced plaintext fallback generator, so this will probably get fixed then.
from gitlab.
Related Issues (20)
- Support for link to artifacts when CI passes
- Change "Gitlab" to "GitLab" HOT 1
- Pushing a rebase yields very large messages HOT 3
- KeyError: 'Deployment Hook'
- Require moderator rights to add webhooks with command
- Delete webhook command
- Doesn't seem to work with multiple accounts HOT 2
- OptRepoArgument does not match all possible repository names HOT 2
- "webhook add" only allows either URL or repository (not both)
- "webhook add" fails to respond in case of invalid repository path
- GitLab plugin fails to start: TypeError: 'ABCMeta' object is not subscriptable HOT 2
- Database error upon first run
- Allow different access_token logins based on project HOT 8
- "Index out of range" when trying to add webhook HOT 1
- honor base_command
- Bot is sending illegal html attributes HOT 1
- Documentation issues in README
- Merge train job events don't get matched
- Use details tag for (long) issue descriptions
- Failed to deserialize lock_on_merge into key labels of GitlabIssueAttributes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitlab.