dangerous packages import about anko HOT 10 CLOSED

Packages now default to having all packages added. You can remove packages as wanted.

If you want to have more than one package config, just import env more than once and configure as you would like.

from anko.

Also note, you can use the Go build flag appengine which will remove some of the packages, like net and net/http, from being adding by default.

from anko.

As far as I know, this global variable is shared among all VMs.
If you change it, you change it for everybody. (and you also get multi-threading issues (as they all use the same global variable, and no mutex protect it))

from anko.

If you import env twice, there will be two env, each with there own Packages varable.

from anko.

so let's do something a bit exagerated:
Let say I have 100 customers, and they all have different configs (packages allowed)
I would have to import manually the "env" a hundred times, and manually configure the packages with all possible combinations ?

from anko.

I get your point, it is not as flexible as before, however, do you understand why this change was made? How env is copied in the VMs and the resource load a VM copy was taking for most use cases?

from anko.

tbh, I don't really know why the change was made. I didn't find any explanations (other than "Simplified packages") in the commit.
This is just something I realized while trying to upgrade the lib in my app.

from anko.

Welcome to ask questions :)

from anko.

I'm curious now !
I guess that loading the packages in the VM was taking more memory than not loading them.
Do you have any benchmark / order of magnitude ? like how much ram it takes to load "math" package for example ?
(I'm genuinely curious. I know I could do the benchmark myself, I'm just curious if you have any numbers at hand)

from anko.

The PR that commit was in had a lot going on. Performance was just a small part of it and not really the main focus. One of the main goals was splitting out env to make things cleaner, especially for testing.

I do not have any benchmarks. Every time a new env was created, all the defines had to be run again. If you had a lot of VMs, this would have taken up a lot of space.

So can you close this issue?

from anko.