Should the commit hook be opinionated about puppet-lint checks? about puppet-pre-commit-hook HOT 2 CLOSED

#23 would make this change.

Pros:

• Future proofed against check name changes
• Being less opinionated allows puppet-lint defaults (which reflect the style guide) to prevail

Cons:

• May allow a user's individual preferences in ~/.puppet-lint.rc take preference if there is no config file in the repo, causing surprise when someone else runs tests, or when that user modifies their personal preferences.

I do feel the pros outweigh the cons, but maybe not?

from puppet-pre-commit-hook.

I completely agree, those puppet-lint defaults were made haphazardly and a long time ago, they are either no longer relevant, obsolete or in need of better defaults.

Best to serve this from a custom ~/.puppet-lint.rc.

from puppet-pre-commit-hook.