Simpler QGramDistances implementation and prep for general dictionaries and iterators about stringdistances.jl HOT 5 CLOSED

The simplest entrypoint might be to check how the qgram.jl file changed in this:

https://github.com/robertfeldt/StringDistances.jl/blob/simpler_counter_design/src/distances/qgram.jl

from stringdistances.jl.

That looks good. Maybe it'd be even better to remove the _count function, and define a countmatches!(mc::AbstractWordMatchCounter, d1::QGramIterator, d2::QGramIterator) method instead.

from stringdistances.jl.

Thanks for taking a look. Hmm, yes, but there would be no performance benefit, right, since we still need to create the full dict currently done in _count. Might clean up the code somewhat but not by much. I guess we might save some memory by not having to send the result from values(d) back but can just iterate over it. Or am I missing something?

BTW, thanks for making me a contributor. Should I still do PRs from my forked repo or is there a simplification in the workflow? (I couldn't see what rights came with the new role).

from stringdistances.jl.

For the workflow, I think the idea is that you should still do PR (as I should, I need to stop committing directly), but then you can merge them by yourself (when you think it is ready, say, after a few days).

For my proposition, yes it’s just about cleaning the code a bit, not about changing performances

from stringdistances.jl.

Could you make a PR with your code? Maybe it's better to un-export QGramDict and QgramSortedVector (or the new names you use). Not sure why I did that in the first place.

from stringdistances.jl.