Postgres DB connection not closed after migrations? about migrate HOT 4 CLOSED

Sorry for my late reply. I was on vacation last week.

Migrate does not seem to close the database after running migrations.

Ah, good point. I see two options:

1. Remove Initialize(url string) error and move all logic from there to Migrate(file file.File, pipe chan interface{}). This means, for every migration file that get's applied, it would open (and close) a connection.
2. Keep Initialize(url string) error and add Close() error which handles all DB connection closing, once all migration files are applied.

I like option 1 more but not sure about the opening/ closing overhead. What do you think?

from migrate.

After some more thoughts, I think it makes more sense to implement option 2. I added a Close() error func to the driver.

@justinas can you check if it works for you, too?

from migrate.

Sorry for delay on my part as well. Option 2 certainly looks more flexible. Just tested it and it seems to work for me.

from migrate.

Great. Will close this issue then.

from migrate.