Code Monkey home page Code Monkey logo

Comments (6)

mattes avatar mattes commented on May 20, 2024

I recently made change to the exit statement. Maybe it is related. Tests in master branch seem to work on travis though? What are you doing exactly?

from migrate.

davidcelis avatar davidcelis commented on May 20, 2024

Sorry I've been quiet on this; the repo in question is private right now while I spec it out but I'm gonna switch it over to public soon. I'll link to it here once that happens.

from migrate.

dkolbly avatar dkolbly commented on May 20, 2024

We've also started to see migrate return non-zero status, but even in success cases and not just in error cases (the code linked above looks like it is intended to return RC 1 in case of error). Is this intended, or a side-effect/bug of something else?

$ migrate -path db -url postgres://xxx:xxx@localhost/database up

0.0684 seconds
$ echo "RC $?"
RC 1
$ migrate -path db -url postgres://xxx:xxx@localhost/database down
< 0001_create_tables.down.sql

0.0333 seconds
$ echo "RC $?"
RC 1
$ migrate -path db -url postgres://xxx:xxx@localhost/database down

0.0239 seconds
$ echo "RC $?"
RC 1

from migrate.

dkolbly avatar dkolbly commented on May 20, 2024

Hmm, I wonder if this line should be returning okFlag instead of false. Looks like writePipe will always signal an error, unless pipe happens to be nil.

from migrate.

dimas-cyriaco avatar dimas-cyriaco commented on May 20, 2024

@dkolbly solution resolves the problem.

from migrate.

mattes avatar mattes commented on May 20, 2024

I merged #27 which should fix this. Sorry for the delay.

from migrate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.