Comments (5)
Ok, I see flags as Subscription fields a good idea. It should also be more efficient than having it in an array of strings as we won't have to iterate just to check if the flag is set. Maybe another struct SubscriptionFlags could be included.
Thanks @hanzei!
from mattermost-plugin-github.
I'd like to work on this! Thanks.
from mattermost-plugin-github.
That's awesome, thanks @enolal826 🎉
from mattermost-plugin-github.
Hello!
Two aspects:
- Since currently no flags are supported, I've thought it'd be more convenient for the Subscription struct to have a "flags" field. What do you think?
- As of now, when subscribing there is just one field "features" supported and is supposed to be a comma-separated string, but other features are also considered:
features = strings.Join(parameters[1:], " ")
It means that for the command
/github subscribe owner/repo pulls,issues anotherThing
both "pulls,issues" and "anotherThing" would be inserted in the "feature" field. I don't know if this is something expected
Thanks!
from mattermost-plugin-github.
- I would like to have the "flags" as boolean fields of in the
Subscription
struct. This way we make sure that we do the parsing of the input only once and then have all data in the struct - That is not expected. "anotherThing" should not go into
Features
.
Let me know, if this resolves your questions.
from mattermost-plugin-github.
Related Issues (20)
- The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). HOT 2
- [Feature request] When linking to pull requests / issues on a private repository, show a preview instead of an error page
- this plugin is totally uselsss waste of time HOT 1
- Ephemeral message "Not able to get list of webhooks" after creating a subscription HOT 3
- `issue_creations` subscription with labels should support labeling an existing issue
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 8
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 1
- Consider implementing subscriptions feature as a form/modal HOT 1
- How to remove GitHub integration in mattermost? HOT 8
- Implement server-side localization for the plugin
- Implement webapp-side localization for the plugin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.