Code Monkey home page Code Monkey logo

Comments (9)

hanzei avatar hanzei commented on June 19, 2024 1

No, there isn't. Without that lint it seams to be hard to identify the context in which a message was attached e.g. when attaching a message from another user.

from mattermost-plugin-github.

AnXh3L0 avatar AnXh3L0 commented on June 19, 2024 1

Understood, it seems I'll have to edit the plugin myself then, thanks for the quick answer!

from mattermost-plugin-github.

niklabh avatar niklabh commented on June 19, 2024

Hey, i would love to work on this.

from mattermost-plugin-github.

mgdelacroix avatar mgdelacroix commented on June 19, 2024

Thanks @niklabh!

from mattermost-plugin-github.

niklabh avatar niklabh commented on June 19, 2024

Here is a pull request: #120

from mattermost-plugin-github.

niklabh avatar niklabh commented on June 19, 2024

Here is the flow for implementations in #120:

  • Click Attach to Github Issue in context menu (shown when user connects his github account with plugin installed) on non system messages
    Screenshot from 2019-09-11 13-26-14
  • Attach to github modal will open
    Screenshot from 2019-09-11 13-26-30
  • You can search the issue. The query to github is is:open is:issue assignee:{connected_user} archived:false [org:{organisation}] [search term]
    Screenshot from 2019-09-11 13-26-47
  • Comment is attached to github
    Screenshot from 2019-09-11 13-37-28

from mattermost-plugin-github.

AnXh3L0 avatar AnXh3L0 commented on June 19, 2024

@niklabh Hi, we are using this plugin on a Mattermost instance of ours but the result after attaching a Mattermost message to an issue is not the same.

Yours contains just the message and that's it, meanwhile ours also adds some unwanted comments on the top, such as, "x user attached x message to issue".

Is there any config I have missed or did this feature actually change in newer PRs? Thanks in advance!

from mattermost-plugin-github.

hanzei avatar hanzei commented on June 19, 2024

Hi @AnXh3L0,

The screenshot above were taken from a WIP prototype. #162 did add the x user attached x message to issue text. It there to make clear where is comment does come from and help with linking Mattermost and GitHub even further together.

from mattermost-plugin-github.

AnXh3L0 avatar AnXh3L0 commented on June 19, 2024

Hi @hanzei,

Thanks for the answer. Is there any way we can remove that line without having to edit and rebuild the whole plugin?

from mattermost-plugin-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.