Comments (7)
@jasonblais I'll try to work on this. My idea are (either):
- Don't trigger mentions from plugins at all, by escaping'@' in https://github.com/mattermost/mattermost-plugin-github/blob/master/server/command.go#L51
- Add a new option under
settings
(ex. 'trigger_mentions') that can have a value of true/false which determines to escape '@' .
What I am not sure is how do you guys do escaping of mentions?
from mattermost-plugin-github.
@dhadiseputro, this is an interesting conundrum. The @
prefixing was recently added to help link a GitHub post back to the Mattermost user of interest. Clicking on a username in that context can be helpful, since it shows the user profile and enables DMs, etc.
There simply currently isn't a way to suppress notifications from an arbitrary post within Mattermost. I'm personally inclined to think that such a feature would be useful, especially for a context like this. @aaronrothschild, maybe this is something to discuss as a higher-level feature request?
from mattermost-plugin-github.
@lieut-data I think this does make sense as something to consider as a higher-level feature. The scenario is similar for our Jira plugin - whenever an activity is detected, we create a DM to that user and it notifies them. We will likely need a an option such as "Do Not trigger Mentions on Jira updates" for example.
from mattermost-plugin-github.
Really an important thing for us, any chance this is getting picked up?
Considering the amount of notifications of pushes, this is basically a blocker in using the plugin at all.
I would really love to have this one configurable at least, or hard opt out for now ( until anything more sophisticated is thought about ).
Beside all that, such a lovely integration, that you so much!
from mattermost-plugin-github.
Thinking about this twice, i really ask myself "when is this ever usefull". Looking at the code at https://github.com/mattermost/mattermost-plugin-github/blob/master/server/template.go#L85 it basically, if possible, finds the mattermost user corresponding to the git user ( if possible ) and notifies this user about his own action.
How does that make any value to the user? Currently, every time i push, i get myself mentioned in the channel.
We understand mentioning a person as an important "please read this" or "please answer this" - neither of this aspects is in charge here.
It is an action which i already 100% know about and which is streamed into the channel for others to "soft notice" like "reading an activity".
I would provide a simple PR for this but i am very undecided if we want this to be configurable, it really sounds far more like a bug then an enhancement after all.
from mattermost-plugin-github.
I'am running the PR #188 on our server now - works like expected (if that helps anybody)
from mattermost-plugin-github.
Little update on my side. Since my patch no longer worked an i did not mind to reroll it against 5.37 i disabled the entire plugin.
I rather go without this plugin and not with the fact that all my collegues learn to entirely ignore notification in mattermost since they are bombed by notifications without any use (i just commited, thank you github to tell me that).
I hope there are at least people being happy with this feature and not all of them are basically trying to learn and ignore those notifications, taking down the entire chat app notifications.
Really would have loved to have this feature, but i guess that is just the difference one has to live with compared to slack - integration level and detail.
from mattermost-plugin-github.
Related Issues (20)
- Feature Request: Subscribe to GitHub Action workflow failures HOT 4
- Feature Request: Subscribe to release events
- The message generated for the `/github subscriptions list ` slash command should show the excluded repositories (if present). HOT 2
- [Feature request] When linking to pull requests / issues on a private repository, show a preview instead of an error page
- this plugin is totally uselsss waste of time HOT 1
- Ephemeral message "Not able to get list of webhooks" after creating a subscription HOT 3
- `issue_creations` subscription with labels should support labeling an existing issue
- Issue/PR descriptions not showing in link tooltips
- Support excluding some users from subscription posts HOT 1
- Support excluding specific comment authors for issue comment subscriptions HOT 6
- For "Issue has been labeled" events, subscriptions do not respect the "render-style" flag for the post size
- Have "PR Merged" subscriptions support filtering labels, for an attached issue
- Subscription posts related to labels should contain a string like "with label x"
- Support `--include-only-org-members` for channel subscriptions HOT 2
- How to troubleshoot? HOT 9
- cleanup / removal of inactive users HOT 6
- Is it possible to make it work properly without setting up the github plugin? HOT 1
- Fix PR subscription error "You cannot update an existing Post" HOT 1
- Consider implementing subscriptions feature as a form/modal HOT 1
- How to remove GitHub integration in mattermost? HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-github.