Bulk indexing small batches can fail about elastigo HOT 5 CLOSED

thank you for great writeup/finding this. I believe there was an error in the logic, i created a unit test that failed, then fixed it, also exposed some of the hidden Global indexor
araddon@b1ed1ec

Logical Error:
araddon@b1ed1ec#L0L178

Ill get a pull request in for this.

from elastigo.

Thanks! It was very late last night when I found this. Thanks for fixing this so fast. Ill pull and give it a whirl.

from elastigo.

Any update on this? I have a problem that may be related: the bulk indexer never finishes. Example:

var done chan bool
bulker := core.NewBulkIndexorErrors(1, 1)
bulker.Run(done)
for ... {
  ...
  bulker.Index("widgets", "widget", i, nil, widget)
}
log.Printf("flushing")
bulker.Flush()
log.Printf("waiting")
done <- true
log.Printf("done")

With any number of documents passed to bulker.Index(), this program hangs at "waiting". The done chan is never read.

Also, a suggestion: I suggest reducing the number of methods available for configuring the bulk indexer and removing the global bulk indexer and the convenience methods. There are currently too many ways to use the bulk indexer and none of them are more powerful or complex than the other. This adds unnecessary complexity to the API.

Thanks for writing this library!!

from elastigo.

Hi Insasho, did you merge Aaron's changes and retest?

Could you write a test for this?

Agreed on the API, it could be simplified. Any suggestions?

On Thu, Jul 4, 2013 at 11:21 AM, insasho [email protected] wrote:

Any update on this? I have a problem that may be related: the bulk indexer
never finishes. Example:

var done chan bool
bulker := core.NewBulkIndexorErrors(1, 1)
bulker.Run(done)
for ... {
...
bulker.Index("widgets", "widget", i, nil, widget)
}
log.Printf("flushing")
bulker.Flush()
log.Printf("waiting")
done <- true
log.Printf("done")

With any number of documents passed to bulker.Index(), this program hangs
at "waiting". The done chan is never read.

Also, a suggestion: I suggest reducing the number of methods available for
configuring the bulk indexer and removing the global bulk indexer and the
convenience methods. There are currently too many ways to use the bulk
indexer and none of them are more powerful or complex than the other. This
adds unnecessary complexity to the API.

Thanks for writing this library!!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-20488927
.

from elastigo.

Closed with #21

from elastigo.