Comments (5)
thank you for great writeup/finding this. I believe there was an error in the logic, i created a unit test that failed, then fixed it, also exposed some of the hidden Global indexor
araddon@b1ed1ec
Logical Error:
araddon@b1ed1ec#L0L178
Ill get a pull request in for this.
from elastigo.
Thanks! It was very late last night when I found this. Thanks for fixing this so fast. Ill pull and give it a whirl.
from elastigo.
Any update on this? I have a problem that may be related: the bulk indexer never finishes. Example:
var done chan bool
bulker := core.NewBulkIndexorErrors(1, 1)
bulker.Run(done)
for ... {
...
bulker.Index("widgets", "widget", i, nil, widget)
}
log.Printf("flushing")
bulker.Flush()
log.Printf("waiting")
done <- true
log.Printf("done")
With any number of documents passed to bulker.Index(), this program hangs at "waiting". The done chan is never read.
Also, a suggestion: I suggest reducing the number of methods available for configuring the bulk indexer and removing the global bulk indexer and the convenience methods. There are currently too many ways to use the bulk indexer and none of them are more powerful or complex than the other. This adds unnecessary complexity to the API.
Thanks for writing this library!!
from elastigo.
Hi Insasho, did you merge Aaron's changes and retest?
Could you write a test for this?
Agreed on the API, it could be simplified. Any suggestions?
On Thu, Jul 4, 2013 at 11:21 AM, insasho [email protected] wrote:
Any update on this? I have a problem that may be related: the bulk indexer
never finishes. Example:var done chan bool
bulker := core.NewBulkIndexorErrors(1, 1)
bulker.Run(done)
for ... {
...
bulker.Index("widgets", "widget", i, nil, widget)
}
log.Printf("flushing")
bulker.Flush()
log.Printf("waiting")
done <- true
log.Printf("done")With any number of documents passed to bulker.Index(), this program hangs
at "waiting". The done chan is never read.Also, a suggestion: I suggest reducing the number of methods available for
configuring the bulk indexer and removing the global bulk indexer and the
convenience methods. There are currently too many ways to use the bulk
indexer and none of them are more powerful or complex than the other. This
adds unnecessary complexity to the API.Thanks for writing this library!!
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-20488927
.
from elastigo.
Closed with #21
from elastigo.
Related Issues (20)
- Issue with reusing connection in another go procedure.. HOT 1
- Testing package is being included due to lib/testsetup.go HOT 2
- tracking individual messages successes or failures in bulkindexer HOT 1
- not support bool query and bool filter? HOT 2
- Race Conditions in corebulk.go
- Index documents to a whole cluster?
- Adding support for the 2.x Query API (and maybe other stuff)
- strings not escaped in WriteBulkBytes
- Support json.UseNumber option HOT 2
- Error Handling
- Possible file descriptor leaks? HOT 2
- making bulkChannel buffer size configurable?
- Amazon ElasticSearch support HOT 1
- Occasional Failed to derive xcontent in bulk index
- MAX_SHUTDOWN_SECS make me get into trouble
- DELETE /_query endpoint removed
- Unmarshal error of parsing shards failures in SearchResult
- gzipped requests omit content-type header
- requests are sent without content-type header HOT 3
- No timeout set for search function in file "coresearch.go"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elastigo.