Drop MATROSKA_VERSION define about libmatroska HOT 6 CLOSED

If this is this thing, it seems to be an error in the packages. The new libmatroska package in your distro should not be mark it as compatible with older versions.
Now, that being said, we thought noone was using this so we are probably the ones to blame.

It's probably this line that needs a fix. I'll submit a patch.

from libmatroska.

libmatroska allows for other people to define MATROSKA_VERSION and only defines it itself if it isn't defined yet. This means that simply removing will break the ABI for people who did define it to be < 2.

Additionally the removal will break the API for any source code checking its value. MKVToolNix used to do this. It doesn't anymore, though.

Yeah, the number of people actually defining it beforehand is probably 0. The number of projects checking its value is potentially higher than 0, though.

I'm not against dropping it, but we should err on the side of caution & explicitly state that such a release will break API & ABI under certain conditions. And bunch the other pending, ABI-breaking PRs in such a release.

from libmatroska.

I don't think it qualifies as an ABI "breakage" if you add new ABI entries but the old ones are unchanged.

I do agree on the API breakage for the define. I was planning to add an #error if it's defined externally to something smaller than 2. So that code that might have used the feature will notice for sure. It's probably a good idea to keep the define to 2 for legacy reasons, as you mentioned.

from libmatroska.

This breaks the latest version of azure-kinect-sensor-sdk.

from libmatroska.

Can you point to some error logs ? It should not be hard to fix.

from libmatroska.

@robUx4
28>D:\buildtrees\azure-kinect-sensor-sdk\src\.0-alpha.0-30d96b3859.clean\src\record\sdk\record.cpp(543,59): error C2065: 'MATROSKA_VERSION': undeclared identifier [D:\buildtrees\azure-kinect-sensor-sdk\x64-windows-dbg\src\record\sdk\k4arecord.vcxproj]

from libmatroska.