Code Monkey home page Code Monkey logo

Comments (5)

mattab avatar mattab commented on August 28, 2024

At least least this should be opt-in, not on by default.

👍

But maybe this can be removed and we don't have to maintain it.

I think it could be useful to users to automatically track exception as Events in their app

from matomo-sdk-android.

d4rken avatar d4rken commented on August 28, 2024

Explicitly tracking exceptions could have some usecase, but even then it's almost always replaceable with if-checks, then track a normal event, which is better practice.

Automaticially tracking all exceptions needs strong filtering and extra options on the server side.
As i said for small apps 5k-20k active users this could work, but even then i would recommend picking something like Crashlytics that was made for this. Having options to hide processed exceptions, stopping reporting from older app versions etc.

If we venture into higher user counts like 100k-150k users, you will get daily crash that are unrelated to your app, but just got caught in your exception handler. With no server-side organisiation, it will spam the event section until it's unusuable.

I would propose to reduce the crash tracking to method that wraps the normal trackEvent method and just converts an Exception object to a useful message. Then remove everything else including automatic exception catching.

I don't want to throw the current piwik-android-sdk over, I'm just speaking out of experience. Sorry for all the scrutiny.

from matomo-sdk-android.

mattab avatar mattab commented on August 28, 2024

Oh it's very useful to have your scrutiny actually!

I would propose to reduce the crash tracking to method that wraps the normal trackEvent method and just converts an Exception object to a useful message. Then remove everything else including automatic exception catching.

Would this change the way the exception are tracked, eg. https://github.com/piwik/piwik-sdk-android#dispatching ? if so please submit the change to documentation with your PR

from matomo-sdk-android.

d4rken avatar d4rken commented on August 28, 2024

No, it will stay the same, I would basically remove the automatic exception handling and then simplify the exposed API.

I'll make a pullrequest when I'm done with the current one and we can discuss it when everyone can see the changes. I can tag you on the pullrequest if you want.

I'll have a look through the docs though to see if it needs updating.

Alexey did an awesome job with what we already have and i followed this project for some time and wished i could have joined sooner.

I currently have a (very patch worky) self made tracking with json + node.js + couchdb and my goal is to replace that with piwik. It's relatively urgend because i underestimated the user growth and amount of data that is to handle. Piwik to the rescue ;).

Got many more ideas and PRs in mind, i hope @dotsbb will like most of them :o.

from matomo-sdk-android.

d4rken avatar d4rken commented on August 28, 2024

My concerns are addressed with PR #33 further discussion can be done there.

from matomo-sdk-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.