Logging or not logging or optional logging? about jvm-breakglass HOT 5 CLOSED

@stanislas as a user of the tool do you have a point of view?

from jvm-breakglass.

I think that the logging is because the numbers of logged event is quite small: at startup and when starting/stoping in between. Also, the "normal" messages are logged at INFO Level, so it is not intrusive.

from jvm-breakglass.

Ok it makes sense. However during the test the number of exceptions logged is quite high even though the tests pass. I think from a testing perspective it can be quite confusing to follow the logs when you see multiple exceptions and stack traces being displayed.

I propose to pass an additional boolean in the NreplServer constructor to make exception logs silent when required. I could use this boolean in during the test to make the log more readable. However the default behaviour i.e. the constuctor with one parameter (port number) would keep logging exception as you suggest (to keep the current behaviour).

I can do that.

Any reserve?

from jvm-breakglass.

Done.

from jvm-breakglass.

it's good for me ;)

from jvm-breakglass.