Code Monkey home page Code Monkey logo

Comments (2)

deecadance avatar deecadance commented on June 10, 2024

I am not a pymatgen developer, but I am working on a class that does basically this.

My two cents are that I would discourage crystal_sg as the amount of handpicked information you need to correctly provide the coordinates in terms of Wyckoff positions to QE is too large, and also you don't get the information back in terms of Wyckoff positions when you relax the structure. I have a prototype version that determines the right ibrav from the space group and gives the atomic coordinates in crystal coordinates. The symmetry is then used anyway.

I cannot estimate when I could polish this enough to directly push it to pymatgen on my own, but I am happy to share what I have done so far if a developer wants to build on it.

from pymatgen.

janosh avatar janosh commented on June 10, 2024

I cannot estimate when I could polish this enough to directly push it to pymatgen on my own, but I am happy to share what I have done

sounds good! if you can provide a good unit tests, i can take care of polishing

from pymatgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.