Comments (2)
from pymatgen.
This is a great idea that I'd love to see implemented.
…
On Mon, Dec 18, 2023, 6:34 PM Richard Tran @.> wrote: Problem At the moment, all analysis in pourbaix_diagram.py assumes that we are operating under room temperature. As a result, we assume all free energies will have a prefactor of 0.0591 for the pH variable i.e. pH * k_B * T * ln(10) (in eV) where T= 298K (RT) and k_B * T * ln(10) = 0.0591. Is there a (chemical or implementation) reason why we do not make this more generalized by adding a temperature variable in the Pourbaix diagrams? Maybe we can set it to a default of T = 298K so the behavior doesn't change, but still allow users to modify if they want to analyze aqueous electrochemical systems under different temperature conditions? If this is reasonable, I can submit a small pull request later to implement Proposed Solution Add a temperature variable that changes the pH prefactor to any method or function that uses "PREFAC". Default all temperature variables to 298K so that the PREFAC value stays at 0.0591 unless the user manually changes temperature. Alternatives No response — Reply to this email directly, view it on GitHub <#3526>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRRSNHQAZAZZTRFR6OKK4DYKD4KRAVCNFSM6AAAAABA2OSIPWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DOOBQGYYDKOI . You are receiving this because you are subscribed to this thread.Message ID: @.>
Sounds good, I was curious what your thoughts on this was going to be. I'll try to make some time this week to push it through. It shouldn't be too much trouble I think
from pymatgen.
Related Issues (20)
- `PBE_64` configured via pmg doesn't work with pymatgen. HOT 9
- Vasprun get_potcars fails if no explicit directories in file path HOT 3
- Bug on DiscretizeOccupanciesTransformation
- Line mode and reciprocal density bug int MPHSEBSSet HOT 2
- Should we let the `StructureMatcher` method work at the affine space group classification level instead of the crystallographic space group classification level? HOT 5
- Finding the Lowest Energy Stacking Configuration for Two Layers with Specific Miller Indices Using Pymatgen. HOT 1
- Error when initializing Vasprun when LDAUL/J or MAGMOM exception triggers
- CifParser check() method does not account for different site multiplicities HOT 1
- POTCAR setup instructions should be made clearer HOT 3
- `bader_analysis_from_path` misusing `_get_filepath` and hence not finding input VASP files HOT 1
- `BadInputSetWarning` should not be raised for ISMEAR = 0 relaxations with metals if SIGMA is small
- `pymatgen.io.res` - compatibility issue with the AIRSS package. HOT 2
- how to load an MD from LAMMPS into a Trajectory object?
- VASP noncollinear Wavecar read error HOT 1
- Is it possible to reduce the size of `tests` directory? HOT 6
- Importing Trajectory from pymatgen.core.trajectory gives an NameError on latest release (2024.2.20) HOT 2
- Can no longer import some modules without having ASE installed HOT 2
- broken BSPlotterProjected.get_projected_plots_dots_patom_pmorb
- [Dev] Tests for `Bader` not running properly HOT 12
- `Structure.replace_species` leaves label intact resulting in confusing/misleading label HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymatgen.