Comments (1)
niekdejonge
commented on June 2, 2024
I tried to quickly implement this in #572
However, I now realize that we need all these different style of inputs for yaml file loading, since the yaml file will store filters as a string.
We could still go for the type:
Tuple[Union[str, Callable], Dict[str, Any]
This would simplify code a bit. And would only need us to change that we always add an empty dictionary in the tuple if no parameters are given.
Alternatively we could reimplement this and do the string parsing within the loading from yaml file or Pipeline Generation.
Both would seem like mayor refactoring, for which I will not have time in my current planning, so this would probably be needed to be picked up by the new software engineer at that point.
from matchms.
Related Issues (20)
- Fix generating empty spectrums HOT 2
- Mismatch between adduct and ionmode after filtering pipeline HOT 2
- Compound name missing in some database entries (matchms database cleaning) HOT 1
- Improvements for matchms cleaning pipeline
- CosineGreedy is unstable
- KeyError: 'scans' during matchms running HOT 1
- Weird `repair_adduct_based_on_smiles` `derive_ionmode` logic? HOT 3
- Reported changes when nothing is changed
- Development setup bugs
- Support GOLM style MSP files
- UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 5: invalid continuation byte HOT 2
- RuntimeError: Wrong peak format detected! HOT 3
- KeyError: 'num peaks'
- Reconsider repairing precursor mz HOT 2
- Split repair_adduct_and_parent_mass_based_on_smiles HOT 1
- Add require filters
- Pipeline should be able to take in custum filters HOT 2
- Should we remove keys that are invalid and if so, which values should we accept?
- Save and load hdf5 representation
- BaseSimilarity.matrix method errors if all scores/matches are 0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from matchms.