Code Monkey home page Code Monkey logo

Comments (12)

mastilver avatar mastilver commented on June 8, 2024 1

should the plugin break when it can't resolve a package?

No, it shouldn't... it should just ignore it... :/

I will need to have a look at that later

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024 1

I found where the error comes from: https://github.com/npm/normalize-package-data/blob/9948ecf3d97cffcaab8f914522a0f3953edac6e4/lib/fixer.js#L335

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024 1

fixed on v3.4.1

from dynamic-cdn-webpack-plugin.

aulisius avatar aulisius commented on June 8, 2024

Fixed this currently by using the only option passed to the plugin, but should the plugin break when it can't resolve a package?

from dynamic-cdn-webpack-plugin.

aulisius avatar aulisius commented on June 8, 2024

I believe adding a .catch block here should at least prevent the plugin from dying.

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024

Can you give me the full stack trace?

Did you install redux-saga?

from dynamic-cdn-webpack-plugin.

aulisius avatar aulisius commented on June 8, 2024

This is when I run without using the only option.

(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: Invalid name: "redux-saga/effects"
(node:13924) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, prom
ise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 6): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 10): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 12): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 14): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 16): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 18): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 20): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 22): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 24): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 26): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 28): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 31): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 34): Error: Invalid name: "redux-saga/effects"
Node#moveTo was deprecated. Use Container#append.
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 36): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 39): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 41): Error: Invalid name: "redux-saga/effects"
(node:13924) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 43): Error: Invalid name: "redux-saga/effects"

And yes, I have installed redux-saga

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024

It reminds me of this issue: import-js/eslint-plugin-import#793

Is it working at all with [email protected]?

from dynamic-cdn-webpack-plugin.

aulisius avatar aulisius commented on June 8, 2024

I didn't get that error with [email protected].

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024

That's it then! :)

Easier to write a test with that information! There is a good chance, it's due to an underlying dependency (I have no idea which one yet). Maybe https://github.com/sindresorhus/resolve-pkg or https://github.com/sindresorhus/read-pkg-up

from dynamic-cdn-webpack-plugin.

mastilver avatar mastilver commented on June 8, 2024

For reference: the issue is caused by this change in redux-saga: redux-saga/redux-saga#895

from dynamic-cdn-webpack-plugin.

aulisius avatar aulisius commented on June 8, 2024

Awesome. Thanks a lot 💯

from dynamic-cdn-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.