Code Monkey home page Code Monkey logo

Comments (5)

maslianok avatar maslianok commented on August 18, 2024

Hi @nealoke,
Thanks for your proposal!

  1. Yeah, that makes sense. Let me play with it a little bit to see all pros and cons.
  2. I think we can use autoprefixer to transform styles during the build process. What versions of IE should we support? IE >=10?

from react-responsive-tabs.

nealoke avatar nealoke commented on August 18, 2024

@maslianok

To me it makes not too much sense to have only text in a tab (because it is in an array or so) :) Would love to put custom components in a tab.

I would go down to 9 or 8 even. (there are more people using these then 10), I know it is a pain.

One more thing that might be nice to have is the ability to only render the selected tab, but on tab switch, don't unmount the component but rather hide it. So in essence you only render the tab's content once. (is this making sense?) :)

from react-responsive-tabs.

LeoAref avatar LeoAref commented on August 18, 2024

@maslianok Do we have any update on the first point? I could make PR for it

from react-responsive-tabs.

maslianok avatar maslianok commented on August 18, 2024

Guys, I'm really sorry for not answering you for a long time.

@LeoAref What benefits do you see in @nealoke's suggestion?
I think you can do the same with our current object-oriented approach. Moreover, now we have getContent function, that helps you to render tabs lazily (I'm not sure that this is possible with suggested approach).

from react-responsive-tabs.

maslianok avatar maslianok commented on August 18, 2024

Close this for now. Please let me know if you want to continue discussion

from react-responsive-tabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.