Code Monkey home page Code Monkey logo

Comments (13)

erikn69 avatar erikn69 commented on June 23, 2024 5

Fixed on #63, please test that branch
Thanks @xel1045 for the suggestions

from flysystem-google-drive-ext.

xel1045 avatar xel1045 commented on June 23, 2024 3

I have the same problem on my side and it seems to be related with the setPathPrefix in method setTeamDriveId. When I update it to the following, listContents works just fine:

    public function setTeamDriveId($teamDriveId, $corpora = 'teamDrive')
    {
        $this->enableTeamDriveSupport();
        $this->optParams = array_merge_recursive($this->optParams, [
            'files.list' => [
                'corpora' => $corpora,
                'includeTeamDriveItems' => true,
                'teamDriveId' => $teamDriveId
            ]
        ]);

        if ($this->root === 'root' || $this->root === null) {
            $this->setPathPrefix(''); // $this->setPathPrefix($teamDriveId);
            $this->root = $teamDriveId;
        }
    }

Also, I see that the parameter includeTeamDriveItems is deprecated and should be replace by includeItemsFromAllDrives (see https://developers.google.com/drive/api/v3/reference/files/list)

from flysystem-google-drive-ext.

xel1045 avatar xel1045 commented on June 23, 2024 3

Good news, I'm really glad it helped!

from flysystem-google-drive-ext.

masterix21 avatar masterix21 commented on June 23, 2024 1

Yes, it is a hack.

from flysystem-google-drive-ext.

rjshreve avatar rjshreve commented on June 23, 2024

For the record, this is cross posted. I asked @erikn69 as well on their repo but we weren’t able to find a solve.

from flysystem-google-drive-ext.

erikn69 avatar erikn69 commented on June 23, 2024

But wich laravel versión? Package versión?

from flysystem-google-drive-ext.

rjshreve avatar rjshreve commented on June 23, 2024

Apologies! Laravel 9, Flysystem 3

from flysystem-google-drive-ext.

erikn69 avatar erikn69 commented on June 23, 2024

I already test team drives, and shared folders on Laravel 9, Flysystem 3, everything working as expected

from flysystem-google-drive-ext.

erikn69 avatar erikn69 commented on June 23, 2024

@xel1045 run the tests, with and without your change
(be carefull with the usePermanentDelete)

from flysystem-google-drive-ext.

masterix21 avatar masterix21 commented on June 23, 2024

@xel1045, thanks: it works for me.

from flysystem-google-drive-ext.

pablomalo-cooperl avatar pablomalo-cooperl commented on June 23, 2024

I have the exact same problem as @rjshreve. The fix proposed by @xel1045 works, thank you for the suggestion. Where do we go from here, @erikn69? Would it be appropriate to open a PR?

from flysystem-google-drive-ext.

masterix21 avatar masterix21 commented on June 23, 2024

Who needs a fix could apply the @xel1045's solution using the spatie/invade package like so:

$adapter = new GoogleDriveAdapter(
    service: new \Google_Service_Drive($client),
    root: '',
    options: [ 'teamDriveId' => $config['teamDriveId'] ]
);

invade($adapter)->setPathPrefix('');

from flysystem-google-drive-ext.

pablomalo-cooperl avatar pablomalo-cooperl commented on June 23, 2024

@masterix21 Yes but that is more of a hack than a fix, right?

Edit: Also, though I recognize the potential usefulness of spatie/invade in working around situations like these, I really feel it is bad practice to trespass on private properties (pun intended).

from flysystem-google-drive-ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.