Code Monkey home page Code Monkey logo

Comments (6)

Marwes avatar Marwes commented on June 5, 2024

That seems a fair change to make. I just followed parsec which only has strings as well and I wasn't aware of any languages which have multiple way of writing the same comment type.

from combine-language.

hawkw avatar hawkw commented on June 5, 2024

It's not terribly common, you're right. Another use-case would be if you're writing an interpreter and you want to ignore shebang lines starting with #! and your line comments begin with a different sigil.

from combine-language.

Marwes avatar Marwes commented on June 5, 2024

#! could be handled easier without this lib though since it only appears in one place. Just add optional(string("#!") ...).with(yourparser) at the entry point of the parser.

I guess the only problem with this change might be how to handled nested comments (if this gets added, Parsec.Token has optionally support for nested comments). I think it should still be alright though.

from combine-language.

hawkw avatar hawkw commented on June 5, 2024

#! could be handled easier without this lib though since it only appears in one place.

True, good point.

from combine-language.

Marwes avatar Marwes commented on June 5, 2024

24c1279 resolves this though it may be good to revisit the implementation since it might not be as efficient as it can be/not generate good error messages.

from combine-language.

Marwes avatar Marwes commented on June 5, 2024

0.6.0 is on crates.io with this change now.

from combine-language.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.