Code Monkey home page Code Monkey logo

Comments (5)

marvinpinto avatar marvinpinto commented on May 31, 2024

In theory this sounds doable but I am not sure how feasible it is in reality, in terms of how much logic changes + maintainability.

If you want to take a quick (prototype) stab at it I'm game - assuming it's not too much work. If it works for me we can add tests & such to prevent future regressions.

from actions.

hwoarang avatar hwoarang commented on May 31, 2024

@marvinpinto maybe it can be solved in a different way

If the GH action created a release object for 1.0.0 and 1.0.1, the changelog should ideally contain all the entries between the two release objects respectively of whether there are semver-like tags in between them.
Say you have a workflow running on this condition:

on:
  push:
    tags:
      - "v[0-9]+.[0-9]+.[0-9]+"

This will run for 1.0.0 and 1.0.1 but not for -rc and -beta.

So in the previous example, 1.0.1-beta and 1.0.1-rc which happen to match semver but they do not have a release object attached to them, they should be simply ignored. Would that make more sense? Unfortunately my JS-foo is not so strong right now to get this working asap :(

The way I see it, I think it makes more sense to base the changelog diff based on the github releases rather than the actual git tags 🤔

from actions.

marvinpinto avatar marvinpinto commented on May 31, 2024

Okay then, I'll take a stab at this if I get some time 👍

(also open to anyone one who's interested)

from actions.

hwoarang avatar hwoarang commented on May 31, 2024

@marvinpinto thank you that would be great!

from actions.

hwoarang avatar hwoarang commented on May 31, 2024

@marvinpinto I took a shot with #30 let me know what you think

from actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.