Code Monkey home page Code Monkey logo

Comments (4)

asbjornu avatar asbjornu commented on May 29, 2024

I would love to help implement this if I knew what to do in order to produce the expected dist/index.js file and then use my forked action in a workflow.

from actions.

marvinpinto avatar marvinpinto commented on May 29, 2024

Hey @asbjornu!

Thanks for sending a PR and apologies for not getting back to you sooner. I think what you are asking for will probably be out of scope for this project. For example: I'm not sure what it would look like for a release already generated on Github - should the changelog be added? Replace what's currently there? How about assets, should they replace the current assets? Or add to them?

I feel like this might get hairy.

You're welcome to use whatever bits necessary to create an action that does what you need. Testing might be tricky with the monorepo structure but should adapt it to a single-repo structure (like other GitHub Actions). I myself use a separate private repo for runs & testing - I didn't bother documenting that here because it's not trivial to replicate.

I'll do my best to help if you need pointers!

from actions.

asbjornu avatar asbjornu commented on May 29, 2024

should the changelog be added?

If there is no changelog, or the one that exists was added by action-automatic-releases (could be "signed" by a simple comment in the description), it should be overwritten. If one exists that wasn't added by action-automatic-releases, leave it.

How about assets, should they replace the current assets?

Since assets are rarely uploaded manually, I'd say replace, yes.

I feel like this might get hairy.

I don't think this is hairy as long as the behaviour is documented and configurable. The allow_duplicates flag would be false by default and by turning it to true, people should know the effects by reading the documentation.

from actions.

marvinpinto avatar marvinpinto commented on May 29, 2024

Thanks for your input @asbjornu 👍

I think the feature you propose would be best implemented in another action. I'd like to keep the scope of this one down as much as possible, to make it easier for me to maintain.

from actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.