Closing termnial window when pressing arrow up about zsh-autocomplete HOT 9 CLOSED

@marlonrichert Works perfectly, thanks!

from zsh-autocomplete.

Stepping through the commits and trying them all out it looks to have happened in this commit: 9d0e92e

from zsh-autocomplete.

Thanks, I’ll have to see if I can reproduce that.

from zsh-autocomplete.

This seems to happen when you don't have Fzf installed, which causes zsh-autocomplete to fall back to the history-search-backward widget. And for some reason, this crashes Zsh. I've experienced similar crashes when trying to use the _history completer. Not sure why or how to work around it. I'll have to investigate some more.

from zsh-autocomplete.

Have fzf installed and in PATH but it happens for me as well, if I comment a line which binds an up arrow in this plugin then it works ok.

from zsh-autocomplete.

@andreypopp Are you sourcing Fzf's keybindings? Without them, the code falls back to using history-search-backward. Simply having Fzf in your path is not enough.

from zsh-autocomplete.

@marlonrichert no, I'm not. Still a bit confusing why it closes the shell on "Up" in that case.

from zsh-autocomplete.

OK, you should source Fzf's keybindings if you want zsh-autocomplete to use Fzf for history search. 🙂

As to why calling any of Zsh's history widgets inside another widget closes the shell, I have no idea. It only works if you call them right away, but if you do anything before that, the shell crashes.

from zsh-autocomplete.

@DanDobrick @andreypopp I pushed in a fix. Please git pull and let me know if it works for you. 🙂

from zsh-autocomplete.