Comments (8)
#define Z_MIN_PROBE_PIN Z_MAX_PIN
was removed from Configuration.h because it doesn't work. It results in the Z_MIN_PROBE_PIN not having a value. That results in the "interrupt-capable" test not being applied to the Z_MIN_PROBE_PIN. Strange stuff happens at compile time.
#define Z_MIN_PROBE_PIN 18
in either Configuration.h or in the pins_YOUR_BOARD.h file works as expected.
As best I can tell, you are correct that there is NOT a default for the Z_MIN_PROBE_PIN. I can't find one in the code and you get a sanity check error when Z_MIN_PROBE_ENDSTOP is enabled but Z_MIN_PROBE_PIN isn't specified.
I'll start a PR to correct the defaults to Z_MAX statement in the Configuration.h files.
from marlindocumentation.
Definitely past my bed time.
The offending statement is in the probes document on the Wiki.
from marlindocumentation.
It's late for me too, but I think you are describing what happens if Z_MIN_ENDSTOP
is not defined.
I spent a whole afternoon looking at this, and there is a default. In some situations. The trouble is the other X (re)definitions in some unknown hierarchy screwing with what I declared.
from marlindocumentation.
screwing with what I declared
If you can provide examples of this I can investigate & see if there is a reasonable explanation.
from marlindocumentation.
PR #86 has been created to delete the Z-MAX default line.
from marlindocumentation.
As I said: Despite the semi-policy of limiting the words in the source, I think it would be kind to mention Z_MIN_ENDSTOP
in that comment.
I did see evidence that something tries to use the z-max pin, but it was obviously from some time ago, because there is a lot of other conflicting code now.
As for redefining things; there's a bunch of stuff related to the bl-touch somewhere obtuse, a bunch in conditional_lcd.h, pins_xxx.h does it too.
I'll raise a separate issue if you think it's worth it.
from marlindocumentation.
I know all about the BLTouch defines. We did it that way to make life simpler for the users which also makes supporting Marlin a lot easier. Unless there's an error or an unusual situation we'll leave them alone.
from marlindocumentation.
Sweet. I was just pointing out some things that caused me pain or looked odd to me.
from marlindocumentation.
Related Issues (20)
- Bed temperature setup issue HOT 1
- M48 should be called Probe Precision (or Repeatability) Test HOT 6
- How to reserve gcodes that in development by Prusa or other firmware? HOT 1
- Configuration Guide Translation - Chinese Simplified HOT 13
- Typo in Configuratio_adv.H HOT 2
- Documentation Suggestion - Identify versions for options HOT 1
- Character LCDs and Graphical LCDs out out of date. HOT 3
- EX.xxx Calucaltion in Marlin Code HOT 1
- content detail request: HOT 1
- Input Shaping dosent work in PrusaSlicer HOT 2
- M593 schouldnt start with 0Hz HOT 1
- Auto Build Not Allowing Me To Set Correct Board HOT 1
- Add explanation of leveling grid to documentation
- [FR] Linear Advance Pattern - Link printed elements to allow analysis of the print surface (and ease removal) HOT 3
- M206 description page HOT 1
- New feature: IS calibration tool HOT 2
- Issue with K-factor Calibration Tool HOT 7
- marlin site links to configurations rather than marlin main branch
- Bed leveling ender 3 v2 HOT 1
- A question regarding the M600 parameters E, U, and L HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marlindocumentation.