Code Monkey home page Code Monkey logo

Comments (13)

markusfisch avatar markusfisch commented on August 17, 2024 1

Well, I didn't have the "Themed icons" switch on my Pixel 7 Pro 🙈 But I found out it's because I don't use the Pixel launcher (I use my own on all of my devices). Curiously, setting the Pixel launcher as the default launcher, doesn't immediately show the option too 🤷‍♂️

Anyway, I just used the emulator to enable themed icons and was able to debug the issue. I misunderstood how monochrome icons should be designed. This is now fixed in dfd6440

I will publish a new version soon. Thanks a lot for reporting! 👍

from binaryeye.

tsiflimagas avatar tsiflimagas commented on August 17, 2024 1

I made a debug build and I confirm the monochrome icon now looks good.
Screenshot_20230130-230956_Arrow Launcher_1.png

from binaryeye.

Mystery00 avatar Mystery00 commented on August 17, 2024

The monochrome icon needs to use android:fillAlpha to represent the difference in color

from binaryeye.

markusfisch avatar markusfisch commented on August 17, 2024

Thanks for fixing this right away 👍

from binaryeye.

tsiflimagas avatar tsiflimagas commented on August 17, 2024

Was this fixed for you? It's still showing like that for me.

from binaryeye.

Mystery00 avatar Mystery00 commented on August 17, 2024

Was this fixed for you? It's still showing like that for me.

Maybe the latest version of Google play doesn't include this commit

from binaryeye.

tsiflimagas avatar tsiflimagas commented on August 17, 2024

I'm on 1.58.0 which should include this commit.

from binaryeye.

Mystery00 avatar Mystery00 commented on August 17, 2024

I am also version 1.58.0 and the monochrome icons are not working correctly

from binaryeye.

markusfisch avatar markusfisch commented on August 17, 2024

Sorry, this isn't easy to test, unfortunately. Somehow I can't enable themed icons on my Pixel 7 🤔

What devices are you on?

from binaryeye.

Mystery00 avatar Mystery00 commented on August 17, 2024

Sorry, this isn't easy to test, unfortunately. Somehow I can't enable themed icons on my Pixel 7 🤔

What devices are you on?

https://www.androidpolice.com/android-13-themed-icons-how-to-activate/

You can check out this tutorial to enable themed icons on Pixel 7, my device is Pixel 6 pro running Android 13

from binaryeye.

Mystery00 avatar Mystery00 commented on August 17, 2024

I made a debug build and I confirm the monochrome icon now looks good.
Screenshot_20230130-230956_Arrow Launcher_1.png

Yep, that's weird why the version distributed by Google play shows the wrong monochrome icon

from binaryeye.

tsiflimagas avatar tsiflimagas commented on August 17, 2024

Because a866a2e didn't fix it, dfd6440 did, which is not in a release yet.

from binaryeye.

tsiflimagas avatar tsiflimagas commented on August 17, 2024

I think this can be closed now.

from binaryeye.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.