This started out as a ticket about Rails 3 support, but has evolved to track s

Some initial work to get rails3 support working has been done in <a class="commit-link

<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github

:format is not supported (formerly "Rails 3 Support") about excursion HOT 2 OPEN

markrebec commented on August 15, 2024

:format is not supported (formerly "Rails 3 Support")

from excursion.

Comments (2)

markrebec commented on August 15, 2024

Some initial work to get rails3 support working has been done in 598afa8

The :format property is completely unsupported for rails3 in this solution, and it's extremely hacky. More work should be done to figure out how to better leverage the action dispatch route mapping in rails 3.

from excursion.

markrebec commented on August 15, 2024

ab60015 made a switch to using the Excursion::Helpers::UrlHelper#replaced_path method and uniform calls to the base ActionDispatch::Http::URL.url_for helper method for Rails 3 and 4.

This means two things:

This is no longer a Rails 3 specific issue. It introduces the :format argument problem into Rails 4, which is bad, but it means we're using the same logic all around, which is good.
I need to put a bit more time into the path part replacement (specifically the :format argument).

from excursion.

Recommend Projects