Deprecation warnings in Chrome about marko HOT 5 CLOSED

@xtremespb this is a known issue. This code is only used when Marko is run in debug mode and it is used to get a stack trace to the point where dom manipulation happened in user and which would break Marko (it can be really helpful there).

Currently this is the only way to do this in the browser although it is deprecated since we only use this when Marko is loaded in debug mode I think it's fine for now until we can come up with a better alternative. MutationObserver (what's recommended as the replacement) does not work for this case since it is batched and loses the relevant stack trace where the mutation occurred.

from marko.

The problem is that I'm running the code built in production mode, built by Webpack.
On some project pages the deprecation warnings are showing in interval.

Is there are a way to disable this behaviour in production mode?

from marko.

@xtremespb if you're seeing the warning in production then it means that when the template was compiled the NODE_ENV was not set (this is what swaps the Marko runtime). When doing a production build can you try setting NODE_ENV=production?

from marko.

@DylanPiercey I've explicitly set MARKO_DEBUG environment variable to false, now it's gone. Setting of NODE_ENV to "production" didn't work.

My suggestion is to set MARKO_DEBUG to "false" as a default value, so for me this seems to be a bug ;-)

from marko.

The debug mode changes a bunch of things, including better error messages, reduced minification and things like this to detect bugs.

Changing the default here doesn't really solve the problem, but we should maybe make it more easy to tell when you're running in a specific mode and also ensure things line up with the build instead of just NODE_ENV at the time of build.

My guess here is that there is something in your webpack config which is causing it not to set NODE_ENV to a const of production. This will cause various tools to pull in debug and unoptimized stuff which isn't great. Can you verify you're webpack config properly sets that?

from marko.