Comments (4)
OK, there IS a workaround, but it is ugly.
I have to say: -DSSL-CONFIG-CLASS=com.marklogic.developer.corb.TwoWaySSLConfig
Which is anything but obvious.
Thing is, if I'm specifying a keystore, it will never work unless I'm using this class, instead of the default "trust anyone" class which does not pass KeyManagers to sslConfig.init(). So if I'm giving the application a keystore and a password for it, it should AUTOMATICALLY pick the correct class instead of stalling out with a mysterious message.
from corb2.
I agree, that it would be more convenient if CoRB automatically applied the TwoWaySSLConfig class if options specific to that implementation are applied to the job (and the user has not explicitly set SSL-CONFIG-CLASS).
Similar to #130 we can look to make configuration easier, and not have to explicitly set every single option.
from corb2.
I have a simple patch for this that I'll send along once the company whose network it's on decides it's OK for me to upload it, which hopefully they will. It was automatically blocked for containing source code. It's just a simple check whether the keystore file is defined, and if so, it selects the "TwoWay" class. Which incidentally is NOT two-way, as it does not check the server certificate.
IMO that part of the application is way over-engineered, but I am not sure it's worth refactoring because of the need for testing.
from corb2.
Here is the patch I'm using:
diff --git a/build.gradle b/build.gradle
index 7970b8a..eec69c3 100644
--- a/build.gradle
+++ b/build.gradle
@@ -96,6 +96,10 @@ dependencies {
testImplementation 'org.jasypt:jasypt:1.9.3'
testImplementation 'com.github.stefanbirkner:system-rules:1.19.0' //facilitates tests for methods that invoke System.exit
testImplementation 'org.mockito:mockito-all:1.10.19'
+ //
+ implementation 'javax.xml.bind:jaxb-api:2.3.1'
+ implementation 'com.sun.xml.bind:jaxb-core:2.3.0.1'
+ implementation 'com.sun.xml.bind:jaxb-impl:2.3.7'
}
test {
diff --git a/src/main/java/com/marklogic/developer/corb/AbstractManager.java b/src/main/java/com/marklogic/developer/corb/AbstractManager.java
index 49b83e8..f178099 100644
--- a/src/main/java/com/marklogic/developer/corb/AbstractManager.java
+++ b/src/main/java/com/marklogic/developer/corb/AbstractManager.java
@@ -28,6 +28,7 @@ import static com.marklogic.developer.corb.Options.XCC_PASSWORD;
import static com.marklogic.developer.corb.Options.XCC_PORT;
import static com.marklogic.developer.corb.Options.XCC_USERNAME;
import static com.marklogic.developer.corb.Options.XCC_PROTOCOL;
+import static com.marklogic.developer.corb.Options.SSL_KEYSTORE;
import static com.marklogic.developer.corb.util.IOUtils.isDirectory;
import com.marklogic.developer.corb.util.NumberUtils;
@@ -264,8 +265,15 @@ public abstract class AbstractManager {
throw new CorbException(MessageFormat.format("Unable to instantiate {0} {1}", SSL_CONFIG_CLASS, sslConfigClassName), ex);
}
} else {
- LOG.log(INFO, () -> "Using TrustAnyoneSSSLConfig because no " + SSL_CONFIG_CLASS + " value specified.");
- sslConfig = new TrustAnyoneSSLConfig();
+ String sslKeystore = getOption(SSL_KEYSTORE);
+ if (sslKeystore != null) {
+ LOG.log(INFO, () -> "SSL_KEYSTORE is defined (as "+sslKeystore+"); using TwoWaySSLConfig.");
+ sslConfig = new TwoWaySSLConfig();
+ }
+ else {
+ LOG.log(INFO, () -> "Using TrustAnyoneSSSLConfig because no " + SSL_CONFIG_CLASS + " value specified.");
+ sslConfig = new TrustAnyoneSSLConfig();
+ }
}
sslConfig.setProperties(properties);
sslConfig.setDecrypter(decrypter);
from corb2.
Related Issues (20)
- Update SSL config to use TLSv1.2 HOT 3
- Issues running Corb via AppServicesPort HOT 5
- SchemaValidateBatchToFileTask not appending content, overwriting with last item
- Better diagnostics for easily detectable developer errors in QueryUrisLoader
- Corb runs selector even when the job is started with COMMAND=STOP
- Option UseConcMarkSweepGC deprecated
- QueryUrisLoader uses Integer.parseInt to obtain total count
- mangled output when default character encoding is not UTF-8
- Job server web page should update after the job completes HOT 2
- CORB running mjs modules issue HOT 1
- Adjustments for Java 11+ and deprecated JAXB javax.xml.bind package HOT 1
- Require PROCESS-MODULE to be set when using Export*ToFileTask
- Suggestion: add deprecated bind libraries to build.gradle HOT 1
- Support external header (and footer) for Module Executor
- expose Manager execError with hasExecError() method
- improve usage messages
- Illegal base64 character encountered in PrivateKeyDecrypter.doDecrypt for unencrypted values that contain - HOT 1
- OPTIONS_FILE assumes ISO 8859-1 encoding HOT 1
- Control logging from command-line options HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from corb2.