Comments (8)
The pattern for this kind of thing thus far has been callback functions that the user can set to provide customized functionality.
I would recommend having an GetClient()
function that returns the http.Client
to use for fetching the URL. By default, this should return a new client, but it could be overridden by calling code (see GetProviderName
) to return the urlfetch.Client
for use on App Engine.
This also has the added benefit of not strongly binding goth
to any app engine code or logic.
@markbates thoughts?
from goth.
Sounds like a valid solution if it is in line with Mark's thoughts.
from goth.
I don't use GAE, so I'm not sure of the exact nature of the problem, so I'll leave this to Tyler's discretion, as he seems to have a handle on this.
from goth.
Sounds good. The approach I posted above should work just fine. @RubenN do you want to go ahead and implement this, then submit a PR?
from goth.
Ok
from goth.
It turned out to be even simpler and doesn't require code changes.
The key is to change the default http client and transport like this:
http.DefaultClient = &http.Client{
Transport: &urlfetch.Transport{Context: c},
}
http.DefaultTransport = &urlfetch.Transport{Context: c}
from goth.
For the record, this does not work anymore with newer versions of oauth2. It looks like it should be unnecessary now, but I can't get it to work at all with oauth2 released after this commit:
golang/oauth2@96e89be
Works if you revert back to before that commit and use @RubenN 's sollution
from goth.
As before, I don't use GAE, so I can't produce. However, @oyvindsk if you can reproduce and know a fix please submit a PR so we can close this. Thanks.
from goth.
Related Issues (20)
- Apple auth with scopes not working correct
- Mastodon OAuth implementation has no handling for the email field.
- wecom provider has bug. cached client will be using for everybody....
- has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
- How to check that users are logged in?
- mailru error
- Bitbucket Authentication Error HOT 1
- Microsoft authentication error
- authentik provider HOT 1
- Group Retrieval For Google Sessions
- Passing parameters between the login and the callback functions HOT 6
- Epic Games Provider
- Could not get name from Google with goth HOT 2
- deprecated lib HOT 1
- Alternative Session option
- global_name in RawData not used in discord provider
- Just a question: how may I tell "goth" library what proxy server it has to use?
- When should you generate the code challenge for a `goth`/`gothic` PKCE OAuth flow? HOT 1
- LinkedIn deprecated OAuth login in favour of OIDC HOT 3
- Session is not saved due to logout
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goth.