Code Monkey home page Code Monkey logo

Comments (6)

markbates avatar markbates commented on July 18, 2024

I'm open for suggestions on how to fix/change things for a potential v2.

from goth.

bryanl avatar bryanl commented on July 18, 2024

I don't think you need do a rev on goth to make this work. This is more commentary about how the slack provider works. It looks to be a simple copy and paste of the box provider without considering how it would actually be used. I'm tweaking a local copy now to see what changes need to be made.

from goth.

bryanl avatar bryanl commented on July 18, 2024

More thoughts on this. IF there was a v2, I would like the ability to have more than one instance of a provider. If you are dealing with a single provider with multiple scopes (because you have multiple users), things can get a bit hairy with the default setup. It's possible to maintain your own list of providers, so this is something that can be worked around.

from goth.

willemvd avatar willemvd commented on July 18, 2024

With #130 it is now possible to set a name to the provider which makes it possible to have multiple instances of the same provider.

https://github.com/markbates/goth/blob/master/provider.go#L15

from goth.

willemvd avatar willemvd commented on July 18, 2024

@bryanl can you confirm if the bot data can be retrieved from the endpointProfile https://slack.com/api/users.info ?

Because if so, it should be available inside gothUser.RawData : https://github.com/markbates/goth/blob/master/providers/slack/slack.go#L116
With that RawData you can than afterwards parse out your requested data

If it is not available, please let me know

from goth.

bentranter avatar bentranter commented on July 18, 2024

Closing this due to age, feel free to re-open if it's still an issue.

from goth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.