_updateHass are called with the same unchanged states about custom-ui HOT 5 CLOSED

This also seems related home-assistant/frontend#16666

from custom-ui.

doesnt the 16666 prove it has nothing to do with custom-ui? and rather its a more generic HA issue?
unless the user is also using custom-ui, it would look for solving that in HA

doesnt mean I am not hoping custom-ui could be optimized, and I have indicated before there's a constant updating going I would love to prevent

as you say:

So every time some state change, we are there and looping thru all states and checking if the entity the state belongs to have template in the list of attributes.

if this PR you suggest would actually stop that from happening, and only check the required states, that would be awesome.

from custom-ui.

doesnt the 16666 prove it has nothing to do with custom-ui? and rather its a more generic HA issue?
unless the user is also using custom-ui, it would look for solving that in HA

Yes and no. As custom-ui is constantly "updating" all its customization's object because of the broken if statements, that is making the HA bug even worse. Custom-ui is constantly triggering the bug by its unnecessary updates.

doesnt mean I am not hoping custom-ui could be optimized, and I have indicated before there's a constant updating going I would love to prevent

This doesn't solve all of them, but at least one of them.

if this PR you suggest would actually stop that from happening, and only check the required states, that would be awesome.

No it doesn't, this PR fixes the BROKEN if statement that will prevent the updates later down the stack if there is checks in place. To me it seems like you don't understand the code in PR at all, is that why you are unsure about this?

At least it will prevent custom-ui to change states that it doesn't need to be changed. Remember, we are high-jacking the method so we don't "own" anything here.

from custom-ui.

its not that I dont understand, its more the fact I want to make sure we are not tailor-made 'fixing' issues in other software that should be generically fixed in that other software.

I can see the value ofc of preventing those useless updates. as a matter of fact, I believe the complete plugin should be reviewed on that aspect, and adjusted.

tbh, Ive stopped using it altogether, moved my icon changes to card-mod, and have created a tiny separate custom-icon-color plugin to do only that (it still uses the old code, attaching the attribute and changing the state badge with it)

having said all of that, I'll approve, and would like to ask if you can write a short and succinct description please, without referring to the Map issue in HA.

thanks for you in depth explanation above, and effort to keep this plugin up to date.

hope you will be able to have a look at the other open issue, where the templates, or more specifically the templates results no longer show as a result when templated in Jinja.
Ill tag you there, maybe you can have a look

from custom-ui.

....would like to ask if you can write a short and succinct description please

Addressed an issue where state objects were inadvertently updated as a result of a comparison error.

from custom-ui.