Can't concat str to bytes error when using _peek_c_type in the Process class about winappdbg HOT 3 CLOSED

I made a pull request which should solve this. #75

from winappdbg.

Hi! Not entirely sure what causes the bug in the first place, I'd rather fully understand the problem before applying a pull request. Can you send me a proof of concept so I can reproduce it on my end? Thanks!

from winappdbg.

For sure. This issue happens because the function _peek_c_type uses the function peek which returns a bytearray when successful but an empty string when an error occurred.

In the case the peek function returns an empty string, the _peek_c_type function crashes line 1996 because it tries to concatenate a bytearray and the empty string.

I have this issue with the sample code passing it the path of any .exe file :

from winappdbg import Debug, EventHandler
import sys

class MyEventHandler(EventHandler):
    def load_dll(self, event):
        module = event.get_module()

def debugger(argv):
    with Debug(MyEventHandler(), bKillOnExit = True) as debug:
        debug.execv(argv)
        debug.loop()

debugger(sys.argv[1:])

The peek function might fail because the Microsoft SDK cannot be found. But it doesn't really matter, I don't think that there should be a concat error in the _peek_c_type function when peek fails.

from winappdbg.