Password prompt when using dbInstance.source(..) about mariadb4j HOT 4 CLOSED

@bjornblomqvist thanks for your interest in this project. A Pull Request to remedy this would be welcome!

from mariadb4j.

So what solution do you think is the right way to go? Also do you need a test for this before you would accept a pull requests?

from mariadb4j.

So what solution do you think is the right way to go?

I like your idea of just treating an emptyString the same as a null value, probably by just using password != null && !password.isEmpty() in https://github.com/vorburger/MariaDB4j/blob/master/mariaDB4j-core/src/main/java/ch/vorburger/mariadb4j/DB.java#L259 ... you could also do it not just for password but also for username & dbName perhaps?

Also do you need a test for this before you would accept a pull requests?

Yes that would be great, please. I'm assuming that it should be trivial to create one... just add an additional line to https://github.com/vorburger/MariaDB4j/blob/master/mariaDB4j/src/test/java/ch/vorburger/mariadb4j/tests/MariaDB4jSampleTutorialTest.java#L75 with "" instead of null - as that tests sources() with null already.

from mariadb4j.

Closing as Done, following merge of https://github.com/vorburger/MariaDB4j/pull/67!

from mariadb4j.