Comments (6)
I would like to handle this issue
from helpafamily.
Hi @ckkeppler, thanks for offering to take this one. It looks like pull request #46 already implemented this as a toggle, but would you be interested on iterating on it further?
For example, if you can think of any ways to make the user experience of the "Anyone in need" toggle or the rest of the form better, a PR would be wonderful. It doesn't have to be a huge change: even text changes to help the form read a bit more elegantly would be greatly appreciated.
from helpafamily.
A couple ways I think this form could be improved further may be to:
Allow the user to select one of the(Implemented by #57)disabled
options, this would have to be rigged up so that theAnyone in need
option is unchecked when one of the other options enabled.Some slight indenting on other options to suggest a hierarchy which shows the relationship between the elements (you often see this done in similar situations)(Not necessary as #57 creates a better interaction for these elements)Ensuring all states have a clean desirable result, i.e. when a selection has been made and the(Fixed by #47)Anyone in need
option is selected after, we get a scenario where the donate message may beHelp Anyone in need, People of Color in Need, Immigrants in Need
which is messy and unnecessary.
I am happy to leave this to others to have a go at as this is not my speciality, however will happily come back with tweaks.
from helpafamily.
@RedFox0x20 Thanks for posting your form improvement ideas. I particularly like this one:
Allow the user to select one of the disabled options, this would have to be rigged up so that the Anyone in need option is unchecked when one of the other options enabled.
@ckkeppler Would you like to try implementing this? You're also welcome to claim any other unclaimed issue and leave this one to someone else. No pressure ๐
from helpafamily.
Oh wow, I see you submitted a PR for this @rathijitpapon. I'll mark this issue as assigned to you then. Thank you so much for that.
@ckkeppler sorry about the confusion, I'm still getting used to how GitHub issue assignment works and should have assigned it to you when you commented. If your schedule permits, take a look at the other issues for anything else that interests you...your help with anything else would be appreciated very much.
from helpafamily.
This is done and merged. I learned some really cool things from your PR @rathijitpapon, thank you! And thank you @RedFox0x20 for all the reviewing help.
from helpafamily.
Related Issues (20)
- โก๏ธ ๐ ๐ โก๏ธ Large Info Section component with animation HOT 4
- โก๏ธ ๐ ๐ โก๏ธ Card Carousel component HOT 4
- โก๏ธ ๐ ๐ โก๏ธ Update visuals of Email Capture and Survey components
- Extra horizontal space on our website
- Ability for radio buttons to revert HOT 3
- Use of Semantic Versioning and Conventional commits. HOT 1
- One can able to figure out that he in on which endpoint from navbar HOT 3
- Set the font size of card's paragraph from 14px to standard size 16px. HOT 3
- Squeezed size of text field HOT 9
- Spacing out the side -bar navigation and introduce some transition HOT 7
- Fix "https://helpafamily.margaritahumanitarian.org/" Laptops for families "learn more" link. HOT 1
- ๐งช โจ Let's Get Code Coverage to 80% โจ HOT 6
- ๐งช ๐ ๐ฅ Build Error From Card Test Coverage `Snap Shot` HOT 5
- [BUG] HOT 1
- Hot Meal Day section HOT 4
- yarn install failed during docker-compose build
- [BUG] Is this project still available HOT 6
- [BUG] @ts-check flags not configured
- [BUG] no TS config found
- [BUG] HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helpafamily.