Code Monkey home page Code Monkey logo

Comments (6)

ckkeppler avatar ckkeppler commented on May 22, 2024

I would like to handle this issue

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

Hi @ckkeppler, thanks for offering to take this one. It looks like pull request #46 already implemented this as a toggle, but would you be interested on iterating on it further?

For example, if you can think of any ways to make the user experience of the "Anyone in need" toggle or the rest of the form better, a PR would be wonderful. It doesn't have to be a huge change: even text changes to help the form read a bit more elegantly would be greatly appreciated.

from helpafamily.

RedFox0x20 avatar RedFox0x20 commented on May 22, 2024

A couple ways I think this form could be improved further may be to:

  • Allow the user to select one of the disabled options, this would have to be rigged up so that the Anyone in need option is unchecked when one of the other options enabled. (Implemented by #57)
  • Some slight indenting on other options to suggest a hierarchy which shows the relationship between the elements (you often see this done in similar situations) (Not necessary as #57 creates a better interaction for these elements)
  • Ensuring all states have a clean desirable result, i.e. when a selection has been made and the Anyone in need option is selected after, we get a scenario where the donate message may be Help Anyone in need, People of Color in Need, Immigrants in Need which is messy and unnecessary. (Fixed by #47)

I am happy to leave this to others to have a go at as this is not my speciality, however will happily come back with tweaks.

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

@RedFox0x20 Thanks for posting your form improvement ideas. I particularly like this one:

Allow the user to select one of the disabled options, this would have to be rigged up so that the Anyone in need option is unchecked when one of the other options enabled.

@ckkeppler Would you like to try implementing this? You're also welcome to claim any other unclaimed issue and leave this one to someone else. No pressure ๐Ÿ™‚

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

Oh wow, I see you submitted a PR for this @rathijitpapon. I'll mark this issue as assigned to you then. Thank you so much for that.

@ckkeppler sorry about the confusion, I'm still getting used to how GitHub issue assignment works and should have assigned it to you when you commented. If your schedule permits, take a look at the other issues for anything else that interests you...your help with anything else would be appreciated very much.

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

This is done and merged. I learned some really cool things from your PR @rathijitpapon, thank you! And thank you @RedFox0x20 for all the reviewing help.

from helpafamily.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.