Comments (7)
Yep, thanks for posting that comment @RedFox0x20, helps me keep track. I know there's a way to auto-resolve issues from a PR merge. I suppose we should look into that at some point.
And thank you again @GrungeKarma for all your contributions. I know you're still new to much of this. I just wanted to say you're doing great. An open-source repo with this much activity is not easy to contribute to, especially while you're learning. Keep up the good work!
from helpafamily.
We don't necessarily have to implement this. See #33 for more info about masonry as an alternative multi-column layout for varying card heights.
from helpafamily.
The cards are now housed in divs with predefined widths making them more standard. If we decided to go down the road of uniformity we will also have to implement a standard height and do some textual content editing.
from helpafamily.
That PR was such a huge help @GrungeKarma. Agreed about your points about choosing a standard height and content editing.
I'd love to hear everyone's thoughts about uniform card heights vs. masonry vs. other approaches.
Also, I'm totally open to PRs with better writing or copy-editing as a means of partially or fully improving how the cards look.
from helpafamily.
I am going to take a look at this one as well.
from helpafamily.
I believe this is no-longer an issue due to #72
from helpafamily.
No problem, I am happy to help and this is a great learning experience.
from helpafamily.
Related Issues (20)
- โก๏ธ ๐ ๐ โก๏ธ Hot Meal Day Section HOT 4
- โก๏ธ ๐ ๐ โก๏ธ Large Info Section component with animation HOT 4
- โก๏ธ ๐ ๐ โก๏ธ Card Carousel component HOT 4
- โก๏ธ ๐ ๐ โก๏ธ Update visuals of Email Capture and Survey components
- Extra horizontal space on our website
- Ability for radio buttons to revert HOT 3
- Use of Semantic Versioning and Conventional commits. HOT 1
- One can able to figure out that he in on which endpoint from navbar HOT 3
- Set the font size of card's paragraph from 14px to standard size 16px. HOT 3
- Squeezed size of text field HOT 9
- Spacing out the side -bar navigation and introduce some transition HOT 7
- Fix "https://helpafamily.margaritahumanitarian.org/" Laptops for families "learn more" link. HOT 1
- ๐งช โจ Let's Get Code Coverage to 80% โจ HOT 6
- ๐งช ๐ ๐ฅ Build Error From Card Test Coverage `Snap Shot` HOT 5
- [BUG] HOT 1
- Hot Meal Day section HOT 4
- yarn install failed during docker-compose build
- [BUG] Is this project still available HOT 6
- [BUG] @ts-check flags not configured
- [BUG] no TS config found
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helpafamily.