Code Monkey home page Code Monkey logo

Comments (7)

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024 1

Yep, thanks for posting that comment @RedFox0x20, helps me keep track. I know there's a way to auto-resolve issues from a PR merge. I suppose we should look into that at some point.

And thank you again @GrungeKarma for all your contributions. I know you're still new to much of this. I just wanted to say you're doing great. An open-source repo with this much activity is not easy to contribute to, especially while you're learning. Keep up the good work!

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

We don't necessarily have to implement this. See #33 for more info about masonry as an alternative multi-column layout for varying card heights.

from helpafamily.

GrungeKarma avatar GrungeKarma commented on May 22, 2024

The cards are now housed in divs with predefined widths making them more standard. If we decided to go down the road of uniformity we will also have to implement a standard height and do some textual content editing.

from helpafamily.

audreyfeldroy avatar audreyfeldroy commented on May 22, 2024

That PR was such a huge help @GrungeKarma. Agreed about your points about choosing a standard height and content editing.

I'd love to hear everyone's thoughts about uniform card heights vs. masonry vs. other approaches.

Also, I'm totally open to PRs with better writing or copy-editing as a means of partially or fully improving how the cards look.

from helpafamily.

GrungeKarma avatar GrungeKarma commented on May 22, 2024

I am going to take a look at this one as well.

from helpafamily.

RedFox0x20 avatar RedFox0x20 commented on May 22, 2024

I believe this is no-longer an issue due to #72

from helpafamily.

GrungeKarma avatar GrungeKarma commented on May 22, 2024

No problem, I am happy to help and this is a great learning experience.

from helpafamily.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.