Comments (7)
Thanks for the report Ripster. Please let me know if you get the chance to create a repro or a patch.
from store.js.
I haven't reproduced this, but am thinking of using store.js in a fairly high-traffic app.
Looking at it, a storage crashbug in IE8 would be caused by store.js using IE8's new globalStorage implementation, so my guess is that #userData would still work in IE8 if it were written to pick that up instead.
I don't want to get mired in browser detection, so I'm just going to swap the if tests so that IE always uses #userData. I doubt this is something you want to include, but thoguht I'd mention it.
from store.js.
jdunck,
what makes you believe that the IE8 crash would be a result of using the globalStorage implementation?
Cheers,
Marcus
from store.js.
Well, I haven't reproduced, but looking at the implementation as it was, it uses globalStorage if it's available.
IE8 ships a globalStorage, and (presuming the crash really happens in IE8), that led me to believe that the globalStorage in IE8 caused the crash.
Do we agree that no web app should be able to crash the browser by using store.js? :-)
I'm just trying to avoid a reported crash; I imagine reproducing it is difficult.
from store.js.
IE8 uses localStorage http://msdn.microsoft.com/en-us/library/cc197062(VS.85).aspx You patch would not solve the issue
Seems like others have seen the same issue: http://osdir.com/ml/javascript-information/2009-11/msg00002.html
Before patching the code it would be nice if we have some data indicating that it fixes the issue. For example, if you can sometimes repro the crash in your browser before your patch, and can never repro the crash in your browser after your patch, then that is a good data point.
from store.js.
Yep, I agree, I'm just in a rush, so forked my hacky way for now. :-)
from store.js.
Closing since it's been a while. Feel free to repoen if relevant.
from store.js.
Related Issues (20)
- Chinese characters when encoding HOT 3
- Ignore me
- how do i read specifically items from session storage HOT 1
- Uncaught TypeError: t.charCodeAt is not a function HOT 2
- Error on Ubuntu: Cannot read property 'documentElement' of undefined HOT 1
- the json format data becomes a json string HOT 1
- how to use store.js with expire?
- Support Subdomains HOT 1
- Open facebook event in new window/tab HOT 1
- there is no Issues just question about security!!! HOT 7
- How to store a file? HOT 13
- clearAll() per namespace? HOT 4
- expire broken HOT 1
- Race conditions HOT 1
- Use Plugins with Typescript HOT 7
- Store instance
- store.js use in memory(localstorage) or physical disk( indexedDB)? what is size limit? HOT 1
- Expiry not set in cookieStorage.js HOT 1
- 存int数组,取值丢失精度 HOT 1
- global namespace
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from store.js.