Code Monkey home page Code Monkey logo

Comments (7)

devjones avatar devjones commented on June 24, 2024 1

My title was inaccurate. It does not render for Reddit on Firefox. Other tests passed

from comments-to-readwise.

devjones avatar devjones commented on June 24, 2024 1

I wasn't aware of anyone else actually using it.

Thanks again for the quick fix. And I recommend you make a Show HN post once the firefox extension is approved. I think lots of people would like to archive insightful comments on HN/reddit as well. My flow is comments -> readwise -> obsidian.

from comments-to-readwise.

devjones avatar devjones commented on June 24, 2024

I'm using the manual install option from https://github.com/marcus-crane/comments-to-readwise#firefox-users

Maybe this will auto-resolve when Firefox supports Manifest v3?

from comments-to-readwise.

marcus-crane avatar marcus-crane commented on June 24, 2024

Hi there,

I'm not sure I understand the scope of the issue since your message is a bit contradictory 😅

You said it does work for Hacker News using Firefox, which would imply the button does appear.

Do you mean that other sites besides HN are working in Chrome but not Firefox?

from comments-to-readwise.

marcus-crane avatar marcus-crane commented on June 24, 2024

Ah ok, I'll have a look 🙂

from comments-to-readwise.

marcus-crane avatar marcus-crane commented on June 24, 2024

Oh! I had forgotten about the state of this extension a bit since I wasn't aware of anyone else actually using it.

At one point, I rewrote it to be easier to extend to new sites going but I hadn't actually ported over the Reddit code: https://github.com/marcus-crane/comments-to-readwise/blob/main/src/content-scripts/sites/reddit-old.ts

The reason it doesn't work is because there's no code for it to execute hah.

It should be easy enough to port over though. The reason it works in Chrome is because that's technically running an older version as there is no automatic update process set up for this extension (yet)

from comments-to-readwise.

marcus-crane avatar marcus-crane commented on June 24, 2024

Hi there,

I've reintroduced the parsing code for old.reddit.com and rewritten it slightly to use the Reddit API instead of extracting content from the page

You can find the latest release for Firefox as an XPI here: https://github.com/marcus-crane/comments-to-readwise/releases/tag/2.1.0

It'll probably be a week or two until you can just install from the store and get auto updates due to the holiday closedowns

from comments-to-readwise.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.