Comments (1)
Hey @hangsu, thanks for bringing this up!
This is indeed something I haven't considered yet, and I'm actually not sure if and how we could support this.
Unless we add a rule that doesn't output the text
call if the method which is being called takes in a block. But I'm not sure if that would be correct in 100% of the cases. Probably not, but it's probably more cases where that would be the more "desirable" outcome.
For the string inside the block we could do something similar as we do with regular HTML elements. Currently this:
<div>123</div>
<div><span>123</span>456</div>
gets converted to:
div { "123" }
div do
span { "123" }
text "456"
end
where we also omit the text
call in the first example if there are other siblings. Maybe we could also do something similar for this case too.
from phlexing.
Related Issues (20)
- Uppercase tag names
- ivars and locals used in ERB attribute interpolation are not respected when generating the `initialize` method
- `<header>` gets treated as `<head>`
- ERB in attributes always outputs parens HOT 1
- ERB attribute interpolation with one static and one dynamic string HOT 5
- More than one ERB interpolation in HTML attribute
- Rails `t` and `translate` helpers
- Style tags gets minified/transformed
- More than one ERB string interpolation in HTML attribute HOT 1
- ERB interpolation within `<style>` tag doesn't work
- Wrong boolean attributes conversion HOT 4
- SVG tags are a special case HOT 1
- Support case-sensitive HTML elements
- https://phlexing.fun is not reachable HOT 2
- Converter doesn't handle non-standard HTML attributes
- Methods that take a block shouldn't be called with `plain`
- Integrate Monaco Editor
- Copy to clipboard button copies old code, not what is in text box HOT 2
- `form_with` short-circuits output HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phlexing.