Code Monkey home page Code Monkey logo

Comments (1)

marcglasberg avatar marcglasberg commented on June 28, 2024

You are right of course, but unfortunately the Locale class doesn't force you to use the correct standards for country and language. You can basically type whatever you want. As a result it's very easy to make mistakes, and the most common one is not using uppercase letters. Try it:

test("Is Locale standardized? No it's not. That's why I normalize it as lowercase.", () {
    expect(Locale("pt", "br").toString(), "pt_br");
    expect(Locale("pt", "BR").toString(), "pt_BR");
    expect(Locale("pt", "BR"), Locale("pt", "BR"));
    expect(Locale("pt", "br"), isNot(Locale("pt", "BR")));
  });

To make it case insensitive, I'm normalizing it in lowercase.

I suggest you open an issue to fix the Locale class itself. Once they fix it I can follow the standard. Or, if they don't, maybe in the future the i18n_extension could make sure the given country and language are following the standard, and then point out the Locale is invalid. But this would force me to validate the Locale, which I don't have enough knowledge to do.

from i18n_extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.