Remove zone.js about ngx-maplibre-gl HOT 6 OPEN

Here is the official documentation about zoneless requirements.

One way would be to use ChangeDetectionStrategy.OnPush for the components.

If thats not possible:

Components can use the Default strategy as long as they notify Angular when change detection needs to run (calling markForCheck, using signals, AsyncPipe, etc.).

Using signals also means input signals instead of the decorator based version.

from ngx-maplibre-gl.

I think that moving to onPush would make this library more performant, but it is also not an easy change, especially since users can add components inside the provided component.
Feel free to push this as I'm not sure I fully know how, up until now I was using Angular without looking into performance stuff and adding onPush, since it's a lot easier to reason with, so I'm not experienced enough with onPush strategy...

from ngx-maplibre-gl.

Is it what you had in mind? It's just the beginning https://github.com/maplibre/ngx-maplibre-gl/pull/167/files

from ngx-maplibre-gl.

I'm not familiar enough with signals, but sure, if this is how it's done.

from ngx-maplibre-gl.

Is it what you had in mind? It's just the beginning https://github.com/maplibre/ngx-maplibre-gl/pull/167/files

I think that is one way to make it compatible with zoneless. Just curious, why you choose model instead of input signal?

from ngx-maplibre-gl.

yeah I think input would be better.

from ngx-maplibre-gl.